From: "Sean Nyekjær" <sean@geanix.com>
To: Conor Dooley <conor@kernel.org>
Cc: robh+dt@kernel.org, Lee Jones <lee@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
pascal Paillet <p.paillet@foss.st.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dt-bindings: mfd: stpmic1: add fsl,pmic-poweroff property
Date: Wed, 24 May 2023 10:16:13 +0200 [thread overview]
Message-ID: <658510B5-702B-464A-BA55-01E2B315BE39@geanix.com> (raw)
In-Reply-To: <20230523-flaccid-fossil-c9d09838dc64@spud>
Hi Conor,
> On 23 May 2023, at 19.29, Conor Dooley <conor@kernel.org> wrote:
>
> On Tue, May 23, 2023 at 11:55:50AM +0200, Sean Nyekjær wrote:
>>> On 16 May 2023, at 20.06, Conor Dooley <conor@kernel.org> wrote:
>>> On Tue, May 16, 2023 at 03:22:24PM +0200, Sean Nyekjaer wrote:
>>>> Document the new optional "fsl,pmic-poweroff" property.
>>>>
>>>> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
>>>> ---
>>>> Documentation/devicetree/bindings/mfd/st,stpmic1.yaml | 8 ++++++++
>>>> 1 file changed, 8 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
>>>> index 9573e4af949e..5183a7c660d2 100644
>>>> --- a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
>>>> +++ b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
>>>> @@ -26,6 +26,14 @@ properties:
>>>>
>>>> interrupt-controller: true
>>>>
>>>> + st,pmic-poweroff:
>>>> + $ref: /schemas/types.yaml#/definitions/flag
>>>> + description: |
>>>> + if present, configure the PMIC to shutdown all power rails when
>>>> + power off sequence have finished.
>>>> + Use this option if the SoC should be powered off by external power management
>>>> + IC (PMIC).
>>>
>>> Just reading this description, this is sounding quite like a "software
>>> behaviour" type of property, which are not permitted, rather than
>>> describing some element of the hardware. Clearly you are trying to solve
>>> an actual problem though, so try re-phrasing the description (and
>>> property name) to focus on what exact hardware configuration it is that
>>> you are trying to special-case.
>>> Krzysztof suggested that the samsung,s2mps11-acokb-ground property in
>>> samsung,s2mps11.yaml is addressing a similar problem, so that could be
>>> good to look at.
>>
>> Better wording?
>> Indicates that the power management IC (PMIC) is used to power off the board.
>> So as the last step in the power off sequence set the SWOFF bit in the
>> main control register (MAIN_CR) register, to shutdown all power rails.
>
> The description for the property that Krzysztof mentioned is
> samsung,s2mps11-acokb-ground:
> description: |
> Indicates that ACOKB pin of S2MPS11 PMIC is connected to the ground so
> the PMIC must manually set PWRHOLD bit in CTRL1 register to turn off the
> power. Usually the ACOKB is pulled up to VBATT so when PWRHOLD pin goes
> low, the rising ACOKB will trigger power off.
>
> In other words, I am asking what (abnormal?) scenario there is that means
> you need the property, rather than what setting the property does.
> Or am I totally off, and this is the only way this PMIC works?
Indicates that the power management IC (PMIC) turn-off condition is met
by setting the SWOFF bit in the main control register (MAIN_CR) register.
Turn-off condition can still be reached by the PONKEY input.
?
I must admit I’m somewhat lost here :)
/Sean
next prev parent reply other threads:[~2023-05-24 8:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 13:22 [PATCH v2 1/3] mfd: stpmic1: fixup main control register and bits naming Sean Nyekjaer
2023-05-16 13:22 ` [PATCH v2 2/3] mfd: stpmic1: add pmic poweroff via sys-off handler Sean Nyekjaer
2023-05-25 11:46 ` Lee Jones
2023-05-16 13:22 ` [PATCH v2 3/3] dt-bindings: mfd: stpmic1: add fsl,pmic-poweroff property Sean Nyekjaer
2023-05-16 18:06 ` Conor Dooley
2023-05-23 9:55 ` Sean Nyekjær
2023-05-23 17:29 ` Conor Dooley
2023-05-24 8:16 ` Sean Nyekjær [this message]
2023-05-24 10:08 ` Conor Dooley
2023-05-24 10:30 ` Sean Nyekjaer
2023-05-24 19:57 ` Conor Dooley
2023-06-01 7:12 ` Krzysztof Kozlowski
2023-06-01 14:05 ` Sean Nyekjaer
2023-06-01 15:25 ` Krzysztof Kozlowski
2023-06-01 20:03 ` Conor Dooley
2023-05-25 11:46 ` [PATCH v2 1/3] mfd: stpmic1: fixup main control register and bits naming Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=658510B5-702B-464A-BA55-01E2B315BE39@geanix.com \
--to=sean@geanix.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.paillet@foss.st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).