From: "Paul Menage" <menage@google.com>
To: balbir@linux.vnet.ibm.com
Cc: containers@lists.linux-foundation.org, vatsa@linux.vnet.ibm.com,
LKML <linux-kernel@vger.kernel.org>,
"Ingo Molnar" <mingo@elte.hu>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: Revert for cgroups CPU accounting subsystem patch
Date: Mon, 12 Nov 2007 23:34:47 -0800 [thread overview]
Message-ID: <6599ad830711122334h34e7958fh26b71bc4c746eec3@mail.gmail.com> (raw)
In-Reply-To: <47395277.1060006@linux.vnet.ibm.com>
On Nov 12, 2007 11:29 PM, Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>
> I think it's a good hack, but not sure about the complexity to implement
> the code. I worry that if the number of tasks increase (say run into
> thousands for one or more groups and a few groups have just a few
> tasks), we'll lose out on accuracy.
But for the case we're looking at, you've already said that you don't
care much about actually controlling CPU, just monitoring it. So what
does it matter if the CPU sharing isn't perfectly accurate? I don't
think that you're painting a realistic scenario.
>
> I think we already have the code, we need to make it more useful and
> reusable.
In that case we should take the existing cpu_acct code out of 2.6.24
until the API has been made more useful and reusable, so that we don't
have to support it for ever.
Paul
next prev parent reply other threads:[~2007-11-13 7:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 5:25 Revert for cgroups CPU accounting subsystem patch Paul Menage
2007-11-13 6:00 ` Srivatsa Vaddagiri
2007-11-13 6:05 ` Paul Menage
2007-11-13 7:00 ` Balbir Singh
2007-11-13 7:10 ` Paul Menage
2007-11-13 7:29 ` Balbir Singh
2007-11-13 7:34 ` Paul Menage [this message]
2007-11-13 7:59 ` Srivatsa Vaddagiri
2007-11-13 7:59 ` Paul Menage
2007-11-13 7:48 ` Srivatsa Vaddagiri
2007-11-13 7:57 ` Paul Menage
2007-11-29 19:17 ` [PATCH] sched: cpu accounting controller Srivatsa Vaddagiri
2007-11-29 19:20 ` Ingo Molnar
2007-11-29 19:39 ` Srivatsa Vaddagiri
2007-11-29 19:30 ` Andrew Morton
2007-11-29 20:18 ` Srivatsa Vaddagiri
2007-11-30 12:42 ` [PATCH] sched: cpu accounting controller (V2) Srivatsa Vaddagiri
2007-11-30 12:35 ` Ingo Molnar
2007-11-30 13:09 ` Srivatsa Vaddagiri
2007-11-30 13:34 ` Ingo Molnar
2007-11-30 12:45 ` Balbir Singh
2007-11-30 13:53 ` Ingo Molnar
2007-11-30 14:00 ` Balbir Singh
2007-11-30 18:45 ` Balbir Singh
2007-11-30 19:46 ` Ingo Molnar
2007-12-01 7:48 ` Paul Menage
2007-12-01 9:51 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830711122334h34e7958fh26b71bc4c746eec3@mail.gmail.com \
--to=menage@google.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=vatsa@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).