From: Hans Verkuil <hverkuil@xs4all.nl>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Arthur Moraes do Lago <arthurmoraeslago@gmail.com>
Cc: mchehab@kernel.org, gregkh@linuxfoundation.org,
mjpeg-users@lists.sourceforge.net, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
lkcamp@lists.libreplanetbr.org
Subject: Re: [PATCH] staging: media: zoran: fix trailing whitespaces
Date: Wed, 10 Apr 2019 12:44:04 +0200 [thread overview]
Message-ID: <65b52cdf-740c-6bc5-ef95-781ddd15fd02@xs4all.nl> (raw)
In-Reply-To: <20190408065103.GA6095@kadam>
On 4/8/19 8:51 AM, Dan Carpenter wrote:
> On Mon, Apr 08, 2019 at 01:35:30AM -0300, Arthur Moraes do Lago wrote:
>> There were several form feeds(^L) in the file, this patch removes them
>> to conform with the coding style.
>>
>> Signed-off-by: Arthur Moraes do Lago <arthurmoraeslago@gmail.com>
>> ---
>> drivers/staging/media/zoran/videocodec.h | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/staging/media/zoran/videocodec.h b/drivers/staging/media/zoran/videocodec.h
>> index 4946791fce0d..c37c0e4fb624 100644
>> --- a/drivers/staging/media/zoran/videocodec.h
>> +++ b/drivers/staging/media/zoran/videocodec.h
>> @@ -49,7 +49,7 @@
>> device dependent and vary between MJPEG/MPEG/WAVELET/... devices. (!!!!)
>> ----------------------------------------------------------------------------
>> */
>> -\f
>> +
>>
>
> Checkpatch also complains if you have two consecutive blank lines so
> really we should just delete the lines entirely... But this driver is
> scheduled for deletion in May. Let's not bother with cleaning it up.
>
> regards,
> dan carpenter
>
I will in fact post a pull request to remove this driver today.
Regards,
Hans
next parent reply other threads:[~2019-04-10 10:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190408043530.21594-1-arthurmoraeslago@gmail.com>
[not found] ` <20190408065103.GA6095@kadam>
2019-04-10 10:44 ` Hans Verkuil [this message]
2019-04-08 4:55 [PATCH] staging: media: zoran: fix trailing whitespaces Arthur Moraes do Lago
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65b52cdf-740c-6bc5-ef95-781ddd15fd02@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=arthurmoraeslago@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lkcamp@lists.libreplanetbr.org \
--cc=mchehab@kernel.org \
--cc=mjpeg-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).