From: Dan Williams <dan.j.williams@intel.com>
To: Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
"Fabio M. De Francesco"
<fabio.maria.de.francesco@linux.intel.com>,
<linux-kernel@vger.kernel.org>
Cc: "Fabio M. De Francesco"
<fabio.maria.de.francesco@linux.intel.com>,
"Peter Zijlstra" <peterz@infradead.org>,
Dan Williams <dan.j.williams@intel.com>,
Ira Weiny <ira.weiny@intel.com>
Subject: Re: [RFC PATCH v2] cleanup: Add cond_guard() to conditional guards
Date: Tue, 30 Jan 2024 16:43:04 -0800 [thread overview]
Message-ID: <65b9979895a8e_5cc6f2942f@dwillia2-mobl3.amr.corp.intel.com.notmuch> (raw)
In-Reply-To: <65b98e8d4f405_2f26102943c@iweiny-mobl.notmuch>
Ira Weiny wrote:
> Dan Williams wrote:
> > Ira Weiny wrote:
> > > Dan Williams wrote:
> > > > Fabio M. De Francesco wrote:
> > > > > Add cond_guard() to conditional guards.
> > > > >
> > > > > cond_guard() is used for the _interruptible(), _killable(), and _try
> > > > > versions of locks. It expects a block where the failure can be handled
> > > > > (e.g., calling printk() and returning -EINTR in case of failure).
> > > > >
> > > > > As the other guards, it avoids to open code the release of the lock
> > > > > after a goto to an 'out' label.
> > > > >
> > > > > This remains an RFC because Dan suggested a slightly different syntax:
> > > > >
> > > > > if (cond_guard(...))
> > > > > return -EINTR;
> > > > >
> > > > > But the scoped_cond_guard() macro omits the if statement:
> > > > >
> > > > > scoped_cond_guard (...) {
> > > > > }
> > > > >
> > > > > Thus define cond_guard() similarly to scoped_cond_guard() but with a block
> > > > > to handle the failure case:
> > > > >
> > > > > cond_guard(...)
> > > > > return -EINTR;
> > > >
> > > > That's too subtle for me, because of the mistakes that can be made with
> > > > brackets how about a syntax like:
> > > >
> > > > cond_guard(..., return -EINTR, ...)
> > > >
> > > > ...to make it clear what happens if the lock acquisition fails without
> > > > having to remember there is a hidden incomplete "if ()" statement in
> > > > that macro? More below...
> > >
> > > I sympathize with the hidden "if" being confusing but there is already
> > > precedent in the current *_guard macros. So I'd like to know if Peter has
> > > an opinion.
> >
> > What are you asking specifically? The current scoped_cond_guard()
> > already properly encapsulates the "if ()" and takes an "_fail" so why
> > wouldn't cond_guard() also safely encpsulate an "if ()" and take an
> > "_fail" statement argument?
>
> Maybe I misunderstood you. I thought you were advocating that the 'if'
> would not be encapsulated. And I was wondering if Peter had an opinion.
>
Last I sent to Fabio was this:
>> You can steal the embedded "if ()" trick from scoped_cond_guard() and do
>> something like (untested):
>>
>> #define cond_guard(_name, _fail, args...) \
>> CLASS(_name, scope)(args); \
>> if (!__guard_ptr(_name)(&scope)) _fail; else /* pass */;
> But if you are agreeing with the direction of this patch regarding the if
> then ignore me.
I disagree with the proposal that the caller needs to understand that
the macro leaves a dangling "if ()". I am ok with aligning with
scoped_cond_guard() where the caller can assume that the "_fail"
statement has been executed with no "if ()" sequence to terminate.
prev parent reply other threads:[~2024-01-31 0:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 16:38 [RFC PATCH v2] cleanup: Add cond_guard() to conditional guards Fabio M. De Francesco
2024-01-30 17:02 ` Dan Williams
2024-01-30 17:33 ` Fabio M. De Francesco
2024-01-30 17:58 ` Dan Williams
2024-01-31 13:11 ` Fabio M. De Francesco
2024-01-30 17:55 ` Fabio M. De Francesco
2024-01-30 18:43 ` Ira Weiny
2024-01-30 19:06 ` Dan Williams
2024-01-31 0:04 ` Ira Weiny
2024-01-31 0:43 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65b9979895a8e_5cc6f2942f@dwillia2-mobl3.amr.corp.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=fabio.maria.de.francesco@linux.intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).