From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B8F1C433EF for ; Fri, 22 Jul 2022 03:31:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231338AbiGVDbG (ORCPT ); Thu, 21 Jul 2022 23:31:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbiGVDbB (ORCPT ); Thu, 21 Jul 2022 23:31:01 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62E351EED1 for ; Thu, 21 Jul 2022 20:31:00 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id t2-20020a17090a4e4200b001f21572f3a4so3143318pjl.0 for ; Thu, 21 Jul 2022 20:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=/6Cb+8ADjWlGk1byx/gAv/ihrtjQyQM76AvewJ6raf0=; b=BEcZ5flLoTHKRlHcKGFXMGAK7PHpb1lCc5CBQgqqBDPQZQov25dfqyGsbsOsMv58tC UWjpwrPMbpT9fbLDpnXgRFmNstXP+69Ef2iw0cbtTSsGmRVSpa5ezEmPAM9zAdbntHmQ vudbUgEwJCcqnJZluroo91MVQykacN2gKArJBnEZD3JkVhIOqU7bGDha8UJ9nZLUeWjw TVammewdtB4Ni44XWU8JPxA4Vs7a1tnJuCT6gtRAi9rKZUOKxupeFCKPBQ7q3iitiObT fhJbN/aP282dSdyT8SEFzcZKp3w8dJnV7XULvZvmq9IOZAn6IuznR44/ylYwVWiVXr06 zAQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=/6Cb+8ADjWlGk1byx/gAv/ihrtjQyQM76AvewJ6raf0=; b=k4uQiG8JPhSFIdcCa0DiSDZ7JS3EjpmH+josz0MOFUe6lIwoz0Gb0hnRaCxFH5Cefg z7mWiOoePMGhl5Qc8YgjBbfPFJF6w9iQ89pLkjSy3nDyUZYwJ6RENi5W3L8W7IyXn8jR CjbwRsbsHzhCiiZMDhtG9dWn6iU6KNUddQM6n7nbzz9vkIIT3/LxE2CY5u1rLUzjiZsq 4hCMuZcLKT2MHClA1NnnqJd5wFoqacLFBlY5rsbn8PTjgRIeJPlyCv+bS5j/Gg2crq+f UceUaZPcn8tr3Hdr/xkH3Bq8pFqtz17ztDu63zBh9KymAiQo1VRTSK5ZQmTMeWODNviQ W4ag== X-Gm-Message-State: AJIora9mePqXthkUX84dr58WYCzuReJH344ffkwnrUMyvIPFykqqKe8S J2f5OCzu3Kmh2g+8nklk4JEeoA== X-Google-Smtp-Source: AGRyM1u66qOMhw/FmNyZzsrbRNGdNOEwQPTR6etWVvS2ZFcBdgNrRnpIXpackB09WcUPNKAXdNW/Dw== X-Received: by 2002:a17:90b:4c4e:b0:1f0:48e7:7258 with SMTP id np14-20020a17090b4c4e00b001f048e77258mr1748828pjb.223.1658460659802; Thu, 21 Jul 2022 20:30:59 -0700 (PDT) Received: from [10.94.58.189] ([139.177.225.254]) by smtp.gmail.com with ESMTPSA id r9-20020aa79889000000b005284d10d8f6sm2538884pfl.215.2022.07.21.20.30.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jul 2022 20:30:59 -0700 (PDT) Message-ID: <65d9f79b-be9b-e21e-0624-5c9f2cc0c0b2@bytedance.com> Date: Fri, 22 Jul 2022 11:30:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 9/9] sched/psi: add PSI_IRQ to track IRQ/SOFTIRQ pressure Content-Language: en-US To: Chengming Zhou , hannes@cmpxchg.org, surenb@google.com, mingo@redhat.com, peterz@infradead.org, tj@kernel.org, corbet@lwn.net, akpm@linux-foundation.org, rdunlap@infradead.org Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, songmuchun@bytedance.com, cgroups@vger.kernel.org References: <20220721040439.2651-1-zhouchengming@bytedance.com> <20220721040439.2651-10-zhouchengming@bytedance.com> From: Abel Wu In-Reply-To: <20220721040439.2651-10-zhouchengming@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chengming, On 7/21/22 12:04 PM, Chengming Zhou Wrote: > Now PSI already tracked workload pressure stall information for > CPU, memory and IO. Apart from these, IRQ/SOFTIRQ could have > obvious impact on some workload productivity, such as web service > workload. > > When CONFIG_IRQ_TIME_ACCOUNTING, we can get IRQ/SOFTIRQ delta time > from update_rq_clock_task(), in which we can record that delta > to CPU curr task's cgroups as PSI_IRQ_FULL status. The {soft,}irq affection should be equal to all the runnable tasks on that cpu, not only rq->curr. Further I think irqstall is per-cpu rather than per-cgroup. Abel