From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8B88C433DF for ; Tue, 2 Jun 2020 11:11:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95631206E2 for ; Tue, 2 Jun 2020 11:11:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=web.de header.i=@web.de header.b="QlA8fN/T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726647AbgFBLLJ (ORCPT ); Tue, 2 Jun 2020 07:11:09 -0400 Received: from mout.web.de ([212.227.17.11]:40059 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726243AbgFBLLI (ORCPT ); Tue, 2 Jun 2020 07:11:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1591096244; bh=wAC4w7GsX0remXYtsz0+/q5r9dTHAJaLyqVIp9ofCno=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=QlA8fN/T8lLIFAz/KZoHWDcAB8p8C5r2Kin+1LZzw2ZjhgrGAFAKqCcDt+goVxMXD +cOScROdxHL8MnHmZruJlYgLbXmxEl9dUELAC922wASMXdFW5h3SjHkm4PHs8dWIhi WZUy3XaDAwAxoOzTa5PjSIltAh/Q5Af+PrxCZJWI= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([2.243.186.246]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MODmV-1jMc1K36oz-00OX4F; Tue, 02 Jun 2020 13:10:43 +0200 Subject: Re: [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new() To: Dan Carpenter , Dinghao Liu , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Skeggs , David Airlie , Kangjie Lu References: <40d8fb01.db721.17269d3d620.Coremail.dinghao.liu@zju.edu.cn> <20200602102955.GZ30374@kadam> From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <65e3d2b7-b0ad-f387-b8fe-d83ea816a0f6@web.de> Date: Tue, 2 Jun 2020 13:10:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200602102955.GZ30374@kadam> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:uazG0p1YzHXmf3z0hs6p+NcCmKHj9lldr8B5DAKIx1PI79krr1D sRZGw9PeHjCaTXI434td5X6q/9dus1PV6nmoSNWA0z3ez5nPyZj8MvySdQSKJu9jb5M1RUo NApQFX05yN04RNeZypU4m1ZNmvM9qOrtxvP3pY3rVP3dIVzlEBe9IJUuUgnRflssNtrmW/e 8zy62sloEXL1/USkG8qNw== X-UI-Out-Filterresults: notjunk:1;V03:K0:DHRVIPzbTBk=:Z3qDqkVgFdZeUH0Nn58AQS cjTa4y8p1p5a4NTrIYeuyAHBpFGrPaxV+4fi61cPJaPotu+sJYrnc9PFaI77tkACSCJTnGK89 OBRpagnHJcJYprT7wC/j/Nq+auXrjwwaHiBE18eYmNRaJah5eLwDsMYdrtgth+OSE8YtyrSL7 /6x20Cm4YOJb5x8PoxiIJLZu0nROHZF6muaPUSHFslosma1GTAg1alYEAjxe55NPALp0kL1vX zflleM1KtXb4DJFLt0IL3vtr+16g/1DnGFyNlUpd2CGiUl3KPkBHvWfVzJgQQOuDrqHfVtMLu PJWbU+/6iVLPIGWULCWfnDkq0zXJJ5PXVR7go+9JxLZCYqRYQZP5yYFpjhYQPwPWpPeOfRr6Y scpGvNgpe+Z6k7wGER/avMO7VwxbHplTSyvGxwVJJWPixSEVaxnY9SjBspMrREpgqyMk+RKrZ MePbAEdF50LCE80L8FjmvzzqjavmJnD4GlVFQ1BKHiuapjbpdsEEPUDSukQRX+pIc+iZH6TX5 Xdz+nwAsnc8EbjxsCr+CwVPFtHw/zx2SPF/apw3XHzjYDNFcIdDuoI5dJCasivnygBYo7NZIx UNoowCt9ARH18aemxL3uCD/ZJbZu4IaTC6pFgtN0X7Lc0la2RyZPj4buCpfP9pNq6oivv5qk4 00ILbg/vXx3MRoBrPVCWFKR/Htr4obBwGZvSPYwpcBMl3voLCIlbvnqwewHw45HVhDRwnxQRY xBqmMYiXh5VPJ4y2I+b7WBHZ6D4TOV1yWDuKiX/OXYOTj9AVnYPRPN9Z+dhjpoUorslLzs/rT UFcgqojZ/akhSHcQxP14seAwwGj+q61niX3xJoY6g7BlA2EaRhv8c8plqFXRW82rqDo4uKCv1 kKgSHHneWFGAHGmVG0Yc7Imzp9XxYigjNqhhufZhbtfaUNcaw9ct/1H4sXhSNtWe/dKoayX8+ B7g6rJIjnk/0BQUN9WWKncp79iPWj7Ci4WYNkrFy16BNBVaaR0kDvqJK3lebW+rLmegnwh9Dd hfjgMtIdSo+Z5Nu2wbZcSeNyNOcky9pNeZE1OeCVEWUk8BXzbTVqofSTCY64lv7HnFDMTxjNQ ptfzzMjO8qmSPdVdw35qUiFd3uot4HnHGp7hBfAhkOazhGU7ZGXxzb20kPNjdHX0eyE6W0pzF /iG3rlBZop4HGhtSE8merhbpyYjClGI8eFc+B9KTFp7i2CGgU5p7M13UG3M0GQhM5HGRFJfdi 7+BjU1zzL7RLnP8G9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The original patch was basically fine. I propose to reconsider the interpretation of the software situation once = more. * Should the allocated clock object be kept usable even after a successful return from this function? * How much do =E2=80=9Cdestructor=E2=80=9D calls matter here for (sub)devi= ces? > Just add a Fixes tag and resend. This tag can help also. Regards, Markus