From: Bart Van Assche <bvanassche@acm.org>
To: "André Almeida" <andrealmeid@collabora.com>,
"Gabriel Krisman Bertazi" <krisman@collabora.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
axboe@kernel.dk, kernel@collabora.com
Subject: Re: [PATCH v2 1/1] blk-mq: fill header with kernel-doc
Date: Fri, 11 Oct 2019 10:00:41 -0700 [thread overview]
Message-ID: <66011772-9f04-dfc3-611e-7dc820d9263f@acm.org> (raw)
In-Reply-To: <8e20f2c6-c165-5b5f-7497-9472913d0ba8@collabora.com>
On 10/10/19 1:38 PM, André Almeida wrote:
> Seems that it's not clear for me the role of these members. Could you
> please check if those definitions make sense for you?
>
> - hctx->dispatch: This queue is used for requests that are ready to be
> dispatched to the hardware but for some reason (e.g. lack of resources,
> the hardware is to busy and can't get more requests) could not be sent
> to the hardware. As soon as the driver can send new requests, those
> queued at this list will be sent first for a more fair dispatch. Since
> those requests are at the hctx, they can't be requeued or rescheduled
> anymore.
>
> - request_queue->requeue_list: This list is used when it's not possible
> to send the request to the associated hctx. This can happen if the
> associated CPU or hctx is not available anymore. When requeueing those
> requests, it will be possible to send them to new and function queues.
Hi André,
The hctx->dispatch description looks mostly fine. Can the following part
be left out since it looks confusing to me: "Since those requests are at
the hctx, they can't be requeued or rescheduled anymore."
How about changing the requeue_list description into the following:
"requests requeued by a call to blk_mq_requeue_request()".
Thanks,
Bart.
next prev parent reply other threads:[~2019-10-11 17:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 0:14 [PATCH v2 1/1] blk-mq: fill header with kernel-doc André Almeida
2019-10-08 16:35 ` Gabriel Krisman Bertazi
2019-10-08 17:30 ` Bart Van Assche
2019-10-08 18:46 ` Gabriel Krisman Bertazi
2019-10-08 20:01 ` Bart Van Assche
2019-10-10 20:38 ` André Almeida
2019-10-11 17:00 ` Bart Van Assche [this message]
2019-10-08 18:12 ` Bart Van Assche
2019-10-10 20:41 ` André Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66011772-9f04-dfc3-611e-7dc820d9263f@acm.org \
--to=bvanassche@acm.org \
--cc=andrealmeid@collabora.com \
--cc=axboe@kernel.dk \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).