From: Hans Wippel <hwippel@linux.ibm.com>
To: Jason Gunthorpe <jgg@mellanox.com>, Ursula Braun <ubraun@linux.ibm.com>
Cc: linux-rdma@vger.kernel.org, Parav Pandit <parav@mellanox.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/smc: Replace ib_query_gid with rdma_get_gid_attr
Date: Wed, 22 Aug 2018 16:19:37 +0200 [thread overview]
Message-ID: <6612bff3-63cb-6353-a8fa-a7c8a1995e2b@linux.ibm.com> (raw)
In-Reply-To: <20180818021707.GA25026@ziepe.ca>
On 08/18/2018 04:17 AM, Jason Gunthorpe wrote:
> All RDMA ULPs should be using rdma_get_gid_attr instead of
> ib_query_gid. Convert SMC to use the new API.
>
> In the process correct some confusion with gid_type - if attr->ndev is
> !NULL then gid_type can never be IB_GID_TYPE_IB by
> definition. IB_GID_TYPE_ROCE shares the same enum value and is probably
> what was intended here.
>
> Reviewed-by: Parav Pandit <parav@mellanox.com>
> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
I ran a few SMC tests and the changes look good. So, no objections from
our side and thank you for the patch.
Hans
prev parent reply other threads:[~2018-08-22 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-18 2:17 [PATCH] RDMA/smc: Replace ib_query_gid with rdma_get_gid_attr Jason Gunthorpe
2018-08-22 14:19 ` Hans Wippel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6612bff3-63cb-6353-a8fa-a7c8a1995e2b@linux.ibm.com \
--to=hwippel@linux.ibm.com \
--cc=jgg@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=ubraun@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).