From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1C68C433FE for ; Mon, 7 Dec 2020 00:14:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 720DC230FA for ; Mon, 7 Dec 2020 00:14:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728259AbgLGAOC (ORCPT ); Sun, 6 Dec 2020 19:14:02 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:44333 "EHLO wout3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726046AbgLGAOB (ORCPT ); Sun, 6 Dec 2020 19:14:01 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 7FCF15D9; Sun, 6 Dec 2020 19:13:15 -0500 (EST) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Sun, 06 Dec 2020 19:13:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=FXWH2ZnmGhBk6pgYPxR/iThdke31cD5 jkfcX6g/sp80=; b=I9f5I5cDHKgFV2tGYrdOJeP00MJz0m1JeN4fNQ/8vO1OoU3 6yEqHtmiGEGCLm/YhyWN5lsVeBFfvN/lma2r4RRt3i7gis7hyq4Np3mQrNadjvq+ FlcW1Onek0CYl8L80UzlQCNIWnlZKfz+cdtvEDD7rAuMVAvupzZLmCrH98zU5ZP/ nfEK1s0XrLM2ZybiFZveM0TFhA/PpVpsK8TE1WBQ+kA1GiJiLbK/P4Jr+eLc7fTx AovufkAP8DOhpVhiCQ2YAzzm2hfmOTTfYuWOad/EMluYs9DButr4ubctiHOI9nd4 qJp8qh4jFf0zG8o0O40O4ayjXJV9RAzCUZsP3Dw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=FXWH2Z nmGhBk6pgYPxR/iThdke31cD5jkfcX6g/sp80=; b=r3L/83flKI25Qo30XXTpSI Wz5f6cmVecOcR0NjzGgjCctOObxBBKFyavEBq2/wqB8POHZddMEzMFGnQE9BUUAe 514JL7u8KgZzqGRcJNvbzlmzEMmsUXz1kNYsQXKHxXry3vDrE70D5diyO655LEkc vG6QePCvMRzhodYjaeZA728YkZ1AihcVUlDZ/EebZyMUlpQ1nwESp7ugHTZlPaOG MKc8yBNf8MvMEczy/UcFuDmSBSo+IpPwEUL1gUCLjJHNC4qCecKiuSq330YXAW9/ +w3Tu9nQxwcDcgG4wkfDiyuw8/+7GDiyFH5S1xYljp0g1sD5pZnHR4J02NEaVr6A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudejfedgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuggftrf grthhtvghrnhepuddttdekueeggedvtddtueekiedutdfguedutdefieeuteefieelteet vddthfeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvgifsegrjhdrihgurdgruh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 06ED5E00DF; Sun, 6 Dec 2020 19:13:11 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-622-g4a97c0b-fm-20201115.001-g4a97c0b3 Mime-Version: 1.0 Message-Id: <661ad7bc-b299-4ada-be93-4e2925d79143@www.fastmail.com> In-Reply-To: <20201204085150.3063-1-vulab@iscas.ac.cn> References: <20201204085150.3063-1-vulab@iscas.ac.cn> Date: Mon, 07 Dec 2020 10:42:52 +1030 From: "Andrew Jeffery" To: "Xu Wang" , "Felipe Balbi" , "Greg Kroah-Hartman" , "Joel Stanley" , "Tao Ren" , "Benjamin Herrenschmidt" , linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org Subject: =?UTF-8?Q?Re:_[PATCH]_usb:_gadget:_aspeed:_Remove_redundant_null_check_b?= =?UTF-8?Q?efore_clk=5Fdisable=5Funprepare?= Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Dec 2020, at 19:21, Xu Wang wrote: > Because clk_disable_unprepare() already checked NULL clock parameter, > so the additional check is unnecessary, just remove it. > > Signed-off-by: Xu Wang Pity we have to dig through the implementation of clk_disable_unprepare() to figure this out, but oh well. Reviewed-by: Andrew Jeffery > --- > drivers/usb/gadget/udc/aspeed-vhub/core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/core.c > b/drivers/usb/gadget/udc/aspeed-vhub/core.c > index be7bb64e3594..ea47f4b98de9 100644 > --- a/drivers/usb/gadget/udc/aspeed-vhub/core.c > +++ b/drivers/usb/gadget/udc/aspeed-vhub/core.c > @@ -282,8 +282,7 @@ static int ast_vhub_remove(struct platform_device > *pdev) > VHUB_CTRL_PHY_RESET_DIS, > vhub->regs + AST_VHUB_CTRL); > > - if (vhub->clk) > - clk_disable_unprepare(vhub->clk); > + clk_disable_unprepare(vhub->clk); > > spin_unlock_irqrestore(&vhub->lock, flags); > > -- > 2.17.1 > >