From: Logan Gunthorpe <logang@deltatee.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] crypto: hifn_795x: Fix a handful of minor bugs spotted by eye
Date: Wed, 17 May 2017 21:33:22 -0600 [thread overview]
Message-ID: <66259d44-37d3-eac3-7193-1ea9741c793f@deltatee.com> (raw)
In-Reply-To: <20170518032658.GA31836@gondor.apana.org.au>
On 17/05/17 09:26 PM, Herbert Xu wrote:
> On Thu, May 18, 2017 at 11:25:06AM +0800, Herbert Xu wrote:
>> On Fri, Apr 28, 2017 at 11:02:40AM -0600, Logan Gunthorpe wrote:
>>> * Cleaned up the formatting of ablkcipher_get arguments so it complies
>>> with kernel style
>>> * The offset in ablkcipher_get sould be added to the source, not the
>>> destination. We rename it to soffset for clarity.
>>> * dst++ should be dst=sg_next(dst)
>>> * We call kunmap_atomic earlier so we only have to do it once.
>>> * If ablkcipher_get fails, we should probably ensure the request
>>> completes with an error.
>> Please don't mix unrelated changes in the same patch.
Seriously? The patch is tiny and those are all incredibly minor changes.
>> Also was this tested on actual hardware? This is an old driver so
>> it's probably best to just let it be.
No, I don't have that hardware. I sent this patch because you requested it.
> Of course we do want fix the offset issue so could you please send
> a new patch with just that fix?
Sorry, no, I honestly don't see that as worth my time. Feel free to drop
the patch or roll your own.
Logan
next prev parent reply other threads:[~2017-05-18 3:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 17:02 [PATCH] crypto: hifn_795x: Fix a handful of minor bugs spotted by eye Logan Gunthorpe
2017-05-18 3:25 ` Herbert Xu
2017-05-18 3:26 ` Herbert Xu
2017-05-18 3:33 ` Logan Gunthorpe [this message]
2017-05-18 4:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66259d44-37d3-eac3-7193-1ea9741c793f@deltatee.com \
--to=logang@deltatee.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).