From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755023AbdERDdd (ORCPT ); Wed, 17 May 2017 23:33:33 -0400 Received: from ale.deltatee.com ([207.54.116.67]:40764 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754798AbdERDdb (ORCPT ); Wed, 17 May 2017 23:33:31 -0400 To: Herbert Xu References: <1493398960-25643-1-git-send-email-logang@deltatee.com> <20170518032506.GA31773@gondor.apana.org.au> <20170518032658.GA31836@gondor.apana.org.au> Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" From: Logan Gunthorpe Message-ID: <66259d44-37d3-eac3-7193-1ea9741c793f@deltatee.com> Date: Wed, 17 May 2017 21:33:22 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170518032658.GA31836@gondor.apana.org.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 68.147.191.165 X-SA-Exim-Rcpt-To: davem@davemloft.net, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH] crypto: hifn_795x: Fix a handful of minor bugs spotted by eye X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/05/17 09:26 PM, Herbert Xu wrote: > On Thu, May 18, 2017 at 11:25:06AM +0800, Herbert Xu wrote: >> On Fri, Apr 28, 2017 at 11:02:40AM -0600, Logan Gunthorpe wrote: >>> * Cleaned up the formatting of ablkcipher_get arguments so it complies >>> with kernel style >>> * The offset in ablkcipher_get sould be added to the source, not the >>> destination. We rename it to soffset for clarity. >>> * dst++ should be dst=sg_next(dst) >>> * We call kunmap_atomic earlier so we only have to do it once. >>> * If ablkcipher_get fails, we should probably ensure the request >>> completes with an error. >> Please don't mix unrelated changes in the same patch. Seriously? The patch is tiny and those are all incredibly minor changes. >> Also was this tested on actual hardware? This is an old driver so >> it's probably best to just let it be. No, I don't have that hardware. I sent this patch because you requested it. > Of course we do want fix the offset issue so could you please send > a new patch with just that fix? Sorry, no, I honestly don't see that as worth my time. Feel free to drop the patch or roll your own. Logan