From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Juergen Gross <jgross@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Cc: xen-devel@lists.xenproject.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH net-next] xen-netfront: mark expected switch fall-through
Date: Tue, 16 Apr 2019 09:52:42 -0500 [thread overview]
Message-ID: <6641fe7a-b1a2-bd2d-9c4e-7dbc00fec015@embeddedor.com> (raw)
In-Reply-To: <0169c220-8a56-f1cb-1922-d17ea56b1427@suse.com>
On 4/16/19 2:17 AM, Juergen Gross wrote:
> On 15/04/2019 23:11, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/net/xen-netfront.c: In function ‘netback_changed’:
>> drivers/net/xen-netfront.c:2038:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (dev->state == XenbusStateClosed)
>> ^
>> drivers/net/xen-netfront.c:2041:2: note: here
>> case XenbusStateClosing:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
>
Thanks, Juergen.
--
Gustavo
next prev parent reply other threads:[~2019-04-16 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 21:11 [PATCH net-next] xen-netfront: mark expected switch fall-through Gustavo A. R. Silva
2019-04-16 7:17 ` Juergen Gross
2019-04-16 14:52 ` Gustavo A. R. Silva [this message]
2019-04-17 4:03 ` David Miller
2019-04-24 18:49 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6641fe7a-b1a2-bd2d-9c4e-7dbc00fec015@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=boris.ostrovsky@oracle.com \
--cc=davem@davemloft.net \
--cc=jgross@suse.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).