From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5502BC3A589 for ; Thu, 15 Aug 2019 14:10:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 308DE208C2 for ; Thu, 15 Aug 2019 14:10:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732775AbfHOOKr (ORCPT ); Thu, 15 Aug 2019 10:10:47 -0400 Received: from lb2-smtp-cloud8.xs4all.net ([194.109.24.25]:56863 "EHLO lb2-smtp-cloud8.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729918AbfHOOKq (ORCPT ); Thu, 15 Aug 2019 10:10:46 -0400 Received: from [IPv6:2001:420:44c1:2579:f038:4b04:f67a:276f] ([IPv6:2001:420:44c1:2579:f038:4b04:f67a:276f]) by smtp-cloud8.xs4all.net with ESMTPA id yGSehwE19DqPeyGShhYRxZ; Thu, 15 Aug 2019 16:10:43 +0200 Subject: Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION To: Laurent Pinchart , Jacopo Mondi Cc: Mauro Carvalho Chehab , Sakari Ailus , "open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)" , open list References: <20190814202815.32491-1-jacopo@jmondi.org> <20190814202815.32491-3-jacopo@jmondi.org> <20190814224340.GD5015@pendragon.ideasonboard.com> From: Hans Verkuil Message-ID: <664fe7b3-9051-30da-736e-710a4e9cecde@xs4all.nl> Date: Thu, 15 Aug 2019 16:10:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190814224340.GD5015@pendragon.ideasonboard.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfNpjEDNHayoDV3P40HsDxS8NAD4L+NUcTCTsWsE4rG6HlWdsVhfj/KvBgZMxlpUFvYF934r9t6jddaz7xfqNBkNB0vzJgJi3UA5AnvLLtoSNsrNA8MA1 9qDKDpcN4qeoJ47/pKWVXIMSsIJ02DnYp4/6rAQfeZHaLNWiV11Sjone+wfMCnWBxUdDmbM2i3WqA5AITZw1JMmPQTe9mTfz5f3bz/MyG/FCaLonTtcnb/n6 Xdl1d8rlyeq+bMO+y/5Vsjlwrxuw8SRjSnT2on/e/p7A/Ga4exfxfKuAGOUBwWLopB2Ip6YMqp3jHx5X9gfVDzAfheiWtcLmlZTnxgG6UZFg8LEANlR/NP9Z c4lPlkezArQeBp6WK2+kr36qIySksaoagyYAuOhMspsjQxD144jbRy3gdFPmuSJ8qCTz6K11pq4usp5t2ZFZUuNWjrM/ZPUNOzOy0yzNWJL4pidJh0SQF5CH ar8Y7SuFOXuUtNWK Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/15/19 12:43 AM, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Wed, Aug 14, 2019 at 10:28:12PM +0200, Jacopo Mondi wrote: >> Add documentation for the V4L2_CID_LOCATION camera control. The newly >> added read-only control reports the camera device mounting position. >> >> Signed-off-by: Jacopo Mondi >> --- >> .../media/uapi/v4l/ext-ctrls-camera.rst | 23 +++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> >> diff --git a/Documentation/media/uapi/v4l/ext-ctrls-camera.rst b/Documentation/media/uapi/v4l/ext-ctrls-camera.rst >> index 51c1d5c9eb00..fc0a02eee6d4 100644 >> --- a/Documentation/media/uapi/v4l/ext-ctrls-camera.rst >> +++ b/Documentation/media/uapi/v4l/ext-ctrls-camera.rst >> @@ -510,6 +510,29 @@ enum v4l2_scene_mode - >> value down. A value of zero stops the motion if one is in progress >> and has no effect otherwise. >> >> +``V4L2_CID_LOCATION (integer)`` > > Maybe V4L2_CID_CAMERA_SENSOR_LOCATION ? Same for the values below. Probably a better name, if a bit long. But we might need other location controls in the future (e.g. flash location), so CID_LOCATION is just too generic. Regards, Hans > >> + This read-only control describes the camera location by reporting its > > Here too I would mention camera sensor instead of just camera (or > possibly imaging sensor). > >> + mounting position on the device where the camera is installed. This >> + control is particularly meaningful for devices which have a well defined >> + orientation, such as phones, laptops and portable devices as the camera >> + location is expressed as a position relative to the device intended >> + usage position. In example, a camera installed on the user-facing side >> + of a phone device is said to be installed in the ``V4L2_LOCATION_FRONT`` >> + position. > > The DT bindings could use such an example :-) I would extend this to > tablets and laptops. > >> + >> + >> + > > Do we need three blank lines ? > >> +.. flat-table:: >> + :header-rows: 0 >> + :stub-columns: 0 >> + >> + * - ``V4L2_LOCATION_FRONT`` >> + - The camera device is located on the front side of the device. >> + * - ``V4L2_LOCATION_BACK`` >> + - The camera device is located on the back side of the device. >> + >> + >> + >> .. [#f1] >> This control may be changed to a menu control in the future, if more >> options are required. >