From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Enrico Weigelt <info@metux.net>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] devres: allow const resource arguments
Date: Tue, 2 Jul 2019 22:26:14 +0200 [thread overview]
Message-ID: <665cd853-ba34-8913-3b63-a88130eda3f8@metux.net> (raw)
In-Reply-To: <20190628150049.1108048-1-arnd@arndb.de>
On 28.06.19 16:59, Arnd Bergmann wrote:
> devm_ioremap_resource() does not currently take 'const' arguments,
> which results in a warning from the first driver trying to do it
> anyway:
>
> drivers/gpio/gpio-amd-fch.c: In function 'amd_fch_gpio_probe':
> drivers/gpio/gpio-amd-fch.c:171:49: error: passing argument 2 of 'devm_ioremap_resource' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
> priv->base = devm_ioremap_resource(&pdev->dev, &amd_fch_gpio_iores);
> ^~~~~~~~~~~~~~~~~~~
<snip>
I've posted quite the same some time ago - no idea why it got no
response.
Reviwed-By: Enrico Weigelt <info@metux.net>
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
next prev parent reply other threads:[~2019-07-03 0:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 14:59 [PATCH] devres: allow const resource arguments Arnd Bergmann
2019-06-28 15:12 ` Greg Kroah-Hartman
2019-07-02 20:26 ` Enrico Weigelt, metux IT consult [this message]
2019-07-03 8:09 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=665cd853-ba34-8913-3b63-a88130eda3f8@metux.net \
--to=lkml@metux.net \
--cc=akpm@linux-foundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=info@metux.net \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).