From: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
To: Mario Limonciello <mario.limonciello@amd.com>,
Hans de Goede <hdegoede@redhat.com>
Cc: stable@kernel.org, Julian Sikorski <belegdol@gmail.com>,
Mark Gross <mgross@linux.intel.com>,
"open list:AMD PMC DRIVER" <platform-driver-x86@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: amd-pmc: Increase the response register timeout
Date: Tue, 14 Sep 2021 14:08:21 +0530 [thread overview]
Message-ID: <666c9ae0-68d5-6008-6fc8-05d097fe3023@amd.com> (raw)
In-Reply-To: <20210914020115.655-1-mario.limonciello@amd.com>
On 9/14/2021 7:31 AM, Mario Limonciello wrote:
> There have been reports of approximately a 0.9%-1.7% failure rate in SMU
> communication timeouts with s0i3 entry on some OEM designs. Currently
> the design in amd-pmc is to try every 100us for up to 20ms.
>
> However the GPU driver which also communicates with the SMU using a
> mailbox register which the driver polls every 1us for up to 2000ms.
> In the GPU driver this was increased by commit 055162645a40 ("drm/amd/pm:
> increase time out value when sending msg to SMU")
>
> Increase the maximum timeout used by amd-pmc to 2000ms to match this
> behavior. This has been shown to improve the stability for machines
> that randomly have failures.
>
> Cc: stable@kernel.org
> Reported-by: Julian Sikorski <belegdol@gmail.com>
> BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1629
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/platform/x86/amd-pmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c
> index 3481479a2942..d6a7c896ac86 100644
> --- a/drivers/platform/x86/amd-pmc.c
> +++ b/drivers/platform/x86/amd-pmc.c
> @@ -71,7 +71,7 @@
> #define AMD_CPU_ID_YC 0x14B5
>
> #define PMC_MSG_DELAY_MIN_US 100
> -#define RESPONSE_REGISTER_LOOP_MAX 200
> +#define RESPONSE_REGISTER_LOOP_MAX 20000
>
> #define SOC_SUBSYSTEM_IP_MAX 12
> #define DELAY_MIN_US 2000
>
Looks good to me.
Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
next prev parent reply other threads:[~2021-09-14 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 2:01 [PATCH] platform/x86: amd-pmc: Increase the response register timeout Mario Limonciello
2021-09-14 8:38 ` Shyam Sundar S K [this message]
2021-09-14 10:34 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=666c9ae0-68d5-6008-6fc8-05d097fe3023@amd.com \
--to=shyam-sundar.s-k@amd.com \
--cc=belegdol@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).