From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S970108AbdAECWj (ORCPT ); Wed, 4 Jan 2017 21:22:39 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:48965 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967700AbdAECWd (ORCPT ); Wed, 4 Jan 2017 21:22:33 -0500 X-AuditID: b6c32a58-f79726d000001ac1-e0-586dadd99948 Subject: Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy To: Krzysztof Kozlowski Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, bhelgaas@google.com, robh+dt@kernel.org, mark.rutland@arm.com, kgene@kernel.org, kishon@ti.com, jingoohan1@gmail.com, vivek.gautam@codeaurora.org, pankaj.dubey@samsung.com, alim.akhtar@samsung.com, cpgs@samsung.com From: Jaehoon Chung Message-id: <666cecb2-0b38-51ba-be5c-086a709c6e48@samsung.com> Date: Thu, 05 Jan 2017 11:22:17 +0900 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-version: 1.0 In-reply-to: <20170104175257.yte3ntw6nyvh47xt@kozik-lap> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNJsWRmVeSWpSXmKPExsWy7bCmlu7NtbkRBs27LSwezNvGZrGkKcPi 5SFNi/lHzrFarPgyk92i//FrZosLT3vYLM6f38BucXnXHDaLs/OOs1nMOL+PyWLp9YtMFou2 fmG3aN17hN3ixM8dzA78HmvmrWH0uNzXy+Sxc9Zddo8Fm0o9Nq3qZPPo27KK0eP4je1MHp83 yQVwRKXaZKQmpqQWKaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gCd rqRQlphTChQKSCwuVtK3synKLy1JVcjILy6xVYo2NDTSMzQw1zMyMtIzMY61MjIFKklIzbjU do2x4A9Hxbfjr1kbGKeydzFyckgImEh8ufGAGcIWk7hwbz1bFyMXh5DAUkaJj8vOQTntTBK7 L05ghelYuWg2E0RiDqNE57N3jBDOPUaJBcensYBUCQsES/yatQPMFhHQlLj+9ztYN7PAHSaJ bcuFQGw2AR2J7d+OM4HYvAJ2Euf2z2UDsVkEVCVmLGgAi4sKhElsvv+SHaJGUOLH5HtgMzkF LCSeXvgPNVNT4sWXSSwQtrzE5jVvmUEOkhD4yS6xcuo6oAQHkCMrsekAM4TpInH9rRbEM8IS r45vgQaFtMTfpbcYIVq7GSX+fdnIBuH0MErc2rqaCaLKWOL+g3vMEMv4JHp/P2GCGMor0dEm BGF6SMz9ngNhOkpses4HCZ73jBLvF15imsAoPwvJN7OQfDALyQcLGJlXMYqlFhTnpqcWmxaY 6BUn5haX5qXrJefnbmIEJ1ytiB2M/2YEHWIU4GBU4uE90ZAbIcSaWFZcmXuIUYKDWUmEl2cV UIg3JbGyKrUoP76oNCe1+BCjKTCEJzJLiSbnA7NBXkm8oYmZoYmRJRCaG5orifMuqLCOEBJI TyxJzU5NLUgtgulj4uCUamBkfMBn3Nw+feu0osDCwoNnv5dNXyRQ0W9ys6+u51bbrK9bM+/d 23o52o2lVmOvSdZ66WVLrjFNW5Qupeccsa4yov3PuujVT863f9/OUnz0HWflUguRbrNbNydm 7lzx/v7dp43v951LLHb4amD9wV+xJSywNjOAobr19c3v0wx/NyhtWeS2InalEktxRqKhFnNR cSIAupdS9M4DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsVy+t9jQd2ba3MjDFbtVLV4MG8bm8WSpgyL l4c0LeYfOcdqseLLTHaL/sevmS0uPO1hszh/fgO7xeVdc9gszs47zmYx4/w+Joul1y8yWSza +oXdonXvEXaLEz93MDvwe6yZt4bR43JfL5PHzll32T0WbCr12LSqk82jb8sqRo/jN7YzeXze JBfAEeVmk5GamJJapJCal5yfkpmXbqsUGuKma6GkkJeYm2qrFKHrGxKkpFCWmFMK5BkZoAEH 5wD3YCV9uwS3jEtt1xgL/nBUfDv+mrWBcSp7FyMnh4SAicTKRbOZIGwxiQv31rN1MXJxCAnM YpRYcucDM4TzgFFi7swrbCBVwgLBEj3fl7CC2CICmhLX/35nhSh6zyhxum8emMMscIdJYl3/ ZbAdbAI6Etu/HQfbwStgJ3Fu/1ywSSwCqhIzFjQAxTk4RAXCJJ43OkGUCEr8mHyPBcTmFLCQ eHrhPytICbOAusSUKbkgYWYBeYnNa94yT2AEOhOhYxZC1SwkVQsYmVcxSqQWJBcUJ6XnGuWl lusVJ+YWl+al6yXn525iBMfyM+kdjId3uR9iFOBgVOLh7fibEyHEmlhWXJl7iFGCg1lJhJdn VW6EEG9KYmVValF+fFFpTmrxIUZToC8mMkuJJucD00xeSbyhibmJubGBhbmlpYmRkjhv4+xn 4UIC6YklqdmpqQWpRTB9TBycUg2MU9QeOF5zX8v2u+34NKs9P7Me67qm3Va6/4mr1kJd6Vc+ c+fWdhOnDNNTEho3mETelPdHJDlaXv9ttd3n7psQpyr3c5GKAlpLZ7965nb8cdy/c18kl3w7 tFz3ksKhK/E23AoVq7a7ye1ZmqpgrlZ4f32Yfb3bBumIiUl2aj+7Nl6w8rVSKbqtxFKckWio xVxUnAgAGrIGAfsCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170105022217epcas5p3d02865dd923ff68998dd0acd197726be X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7KCV7J6s7ZuIG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?SmFlaG9vbiBDaHVuZxtUaXplbiBQbGF0Zm9ybSBMYWIuG1Nh?= =?UTF-8?B?bXN1bmcgRWxlY3Ryb25pY3MbUzUvU2VuaW9yIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170104123436epcas1p1a729583c3c2307d8539a186f1050ea98 X-RootMTR: 20170104123436epcas1p1a729583c3c2307d8539a186f1050ea98 References: <20170104123435.30740-1-jh80.chung@samsung.com> <20170104123435.30740-3-jh80.chung@samsung.com> <20170104175257.yte3ntw6nyvh47xt@kozik-lap> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/05/2017 02:52 AM, Krzysztof Kozlowski wrote: > On Wed, Jan 04, 2017 at 09:34:32PM +0900, Jaehoon Chung wrote: >> This patch supports to use Generic Phy framework for Exynos PCIe phy. >> When Exynos that supported the pcie want to use the PCIe, >> it needs to control the phy resgister. >> But it should be more complex to control in their own PCIe device drivers. >> >> Currently, there is an exynos5440 case to support the pcie. >> So this driver is based on Exynos5440 PCIe. >> In future, will support the Other exynos SoCs likes exynos5433, exynos7. > > I have troubles understanding this. Please, work on the commit message. > > For the code itself: > Acked-by: Krzysztof Kozlowski > ... but commit message is really important to understand why/what was > done. Will update the commit-msg. Thanks for comments. Best Regards, Jaehoon Chung > > Best regards, > Krzysztof > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >