From: Guenter Roeck <linux@roeck-us.net>
To: JuenKit Yip <JuenKit_Yip@hotmail.com>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] hwmon: (sht3x) add device-tree support
Date: Wed, 21 Jun 2023 08:35:53 -0700 [thread overview]
Message-ID: <6673f3d4-b6d6-4024-8d44-2f120649d937@roeck-us.net> (raw)
In-Reply-To: <DB4PR10MB62611629FD3764FB7FF61D24925DA@DB4PR10MB6261.EURPRD10.PROD.OUTLOOK.COM>
On Wed, Jun 21, 2023 at 11:59:37AM +0800, JuenKit Yip wrote:
> add "compatible" property for supporting device-tree
>
> Signed-off-by: JuenKit Yip <JuenKit_Yip@hotmail.com>
> ---
> drivers/hwmon/sht3x.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/sht3x.c b/drivers/hwmon/sht3x.c
> index 31013b5b6..edcf6820c 100644
> --- a/drivers/hwmon/sht3x.c
> +++ b/drivers/hwmon/sht3x.c
> @@ -923,8 +923,18 @@ static const struct i2c_device_id sht3x_ids[] = {
>
> MODULE_DEVICE_TABLE(i2c, sht3x_ids);
>
> +/* devicetree ID table */
> +static const struct of_device_id sht3x_of_match[] = {
> + { .compatible = "sensirion,sht3x" },
> + { .compatible = "sensirion,sts3x" },
Also needs a separate patch addding the two devices
to Documentation/devicetree/bindings/trivial-devices.yaml.
> + {},
> +};
> +
> static struct i2c_driver sht3x_i2c_driver = {
> - .driver.name = "sht3x",
> + .driver = {
> + .name = "sht3x",
> + .of_match_table = of_match_ptr(sht3x_of_match),
> + },
> .probe = sht3x_probe,
> .id_table = sht3x_ids,
> };
> --
> 2.30.2
>
prev parent reply other threads:[~2023-06-21 15:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230621035937.58721-1-JuenKit_Yip@hotmail.com>
2023-06-21 3:59 ` [RFC PATCH 2/2] hwmon: (sht3x) add device-tree support JuenKit Yip
2023-06-21 15:35 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6673f3d4-b6d6-4024-8d44-2f120649d937@roeck-us.net \
--to=linux@roeck-us.net \
--cc=JuenKit_Yip@hotmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).