From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
kernel@collabora.com,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Tinghan Shen <tinghan.shen@mediatek.com>,
Tzung-Bi Shih <tzungbi@google.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: remoteproc: mediatek: Make l1tcm reg exclusive to mt819x
Date: Wed, 11 May 2022 11:12:45 +0200 [thread overview]
Message-ID: <66796853-efe7-f661-9637-ac6cfefc68e5@linaro.org> (raw)
In-Reply-To: <20220510165016.r7nyck2abt5m4djp@notapiano>
On 10/05/2022 18:50, Nícolas F. R. A. Prado wrote:
>>> Also I had to add a description to the global reg-names, since it
>>> couldn't be neither missing nor empty.
>>
>> It is possible:
>> https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/example-schema.yaml#L91
>>
>> Keep constraints and list of names in properties. Then in allOf:if:then
>> raise minItems or lower maxItems, depending on the variant.
>
> Hi Krzysztof,
>
> that example only shows setting minItems to override the default value, but the
> issue here is that it's not possible to override minItems/maxItems (after
> they're already set, even if implicitly) with a different value in the if.
No, this example shows exactly what you need in first step - make one
item on the list optional.
There are several other examples for the entire picture or different
aproach:
https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/example-schema.yaml#L91
https://elixir.bootlin.com/linux/v5.18-rc2/source/Documentation/devicetree/bindings/clock/samsung,exynos7885-clock.yaml#L53
>
> That is:
>
> properties:
> reg-names:
> items:
> - const: sram
> - const: cfg
> - const: l1tcm
You did not use the example I gave you. Where is the minItems?
>
> if:
> properties:
> compatible:
> enum:
> - mediatek,mt8183-scp
> - mediatek,mt8186-scp
> then:
> properties:
> reg-names:
> minItems: 2
> maxItems: 2
>
> Generates the error on dtbs_check:
>
> /home/nfraprado/ext/git/linux/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb: scp@10500000: reg-names: ['sram', 'cfg'] is too short
Missing minItems in first properties.
>
> I believe the tooling is implicitly adding
>
> minItems: 3
> maxItems: 3
>
> to the common reg-names, and since it's not possible to override them, the
> override to 2 doesn't work so they are kept at 3, causing the error.
>
> Moving the minItems/maxItems to the common reg-names as a test gives:
You cannot just. You need it in both places.
>
> /home/nfraprado/ext/git/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml: properties:reg-names: {'minItems': 2, 'maxItems': 2, 'items': [{'const': 'sram'}, {'const': 'cfg'}, {'const': 'l1tcm'}]} should not be valid under {'required': ['maxItems']}
> hint: "maxItems" is not needed with an "items" list
>
> That error, plus looking in the items meta-schema, suggests me that maxItems
> isn't supposed to be set lower then the length of items. So even if the
> minItems/maxItems override is fixed, there's still this issue. It seems like
> defining the reg-names list separetely in each if branch is indeed the right way
> to go.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-11 9:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 21:32 [PATCH v4 0/2] Mediatek SCP dt-binding tweaks Nícolas F. R. A. Prado
2022-05-06 21:32 ` [PATCH v4 1/2] dt-bindings: remoteproc: mediatek: Make l1tcm reg exclusive to mt819x Nícolas F. R. A. Prado
2022-05-07 16:33 ` Krzysztof Kozlowski
2022-05-10 16:50 ` Nícolas F. R. A. Prado
2022-05-11 9:12 ` Krzysztof Kozlowski [this message]
2022-05-11 9:14 ` Krzysztof Kozlowski
2022-05-11 19:58 ` Nícolas F. R. A. Prado
2022-05-09 2:27 ` Tzung-Bi Shih
2022-05-09 15:05 ` Nícolas F. R. A. Prado
2022-05-06 21:32 ` [PATCH v4 2/2] dt-bindings: remoteproc: mediatek: Add optional memory-region to mtk,scp Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66796853-efe7-f661-9637-ac6cfefc68e5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=tinghan.shen@mediatek.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).