From: <Mario_Limonciello@Dell.com>
To: <ming.lei@canonical.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/3] dell_rbu: Don't fallback to userhelper
Date: Wed, 1 Jun 2016 15:35:39 +0000 [thread overview]
Message-ID: <669ce00ff2ff4641b78ee048cb0693e0@ausx13mpc124.AMER.DELL.COM> (raw)
In-Reply-To: <1463423270-24348-1-git-send-email-mario_limonciello@dell.com>
> -----Original Message-----
> From: Limonciello, Mario
> Sent: Monday, May 16, 2016 1:28 PM
> To: ming.lei@canonical.com
> Cc: LKML <linux-kernel@vger.kernel.org>; Limonciello, Mario
> <Mario_Limonciello@Dell.com>
> Subject: [PATCH v2 1/3] dell_rbu: Don't fallback to userhelper
>
> when loading firmware dell_rbu previously would allow a userspace
> application to craft the payload after dell_rbu was loaded and abuse the
> udev userspace API.
>
> Instead require the payload to be crafted and placed in
> /lib/firmware/dell_rbu ahead of time.
>
> This adjusts dell_rbu to immediately load the firmware from
> /lib/firmware/dell_rbu when "init" is passed into image_type using the
> kernel helper.
>
> Signed-off-by: Mario Limonciello <mario_limonciello@dell.com>
> ---
> drivers/firmware/Kconfig | 1 -
> drivers/firmware/dell_rbu.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index
> 6664f11..85afe59 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -86,7 +86,6 @@ config DELL_RBU
> tristate "BIOS update support for DELL systems via sysfs"
> depends on X86
> select FW_LOADER
> - select FW_LOADER_USER_HELPER
> help
> Say m if you want to have the option of updating the BIOS for your
> DELL system. Note you need a Dell OpenManage or Dell Update
> package (DUP) diff --git a/drivers/firmware/dell_rbu.c
> b/drivers/firmware/dell_rbu.c index 2f452f1..77b2a77 100644
> --- a/drivers/firmware/dell_rbu.c
> +++ b/drivers/firmware/dell_rbu.c
> @@ -620,7 +620,7 @@ static ssize_t write_rbu_image_type(struct file *filp,
> struct kobject *kobj,
> if (!rbu_data.entry_created) {
> spin_unlock(&rbu_data.lock);
> req_firm_rc =
> request_firmware_nowait(THIS_MODULE,
> - FW_ACTION_NOHOTPLUG, "dell_rbu",
> + FW_ACTION_HOTPLUG, "dell_rbu",
> &rbu_device->dev, GFP_KERNEL, &context,
> callbackfn_rbu);
> if (req_firm_rc) {
> --
> 2.7.4
Hi Ming,
Could you comment on these patches? There isn't currently a subsystem maintainer for dell_rbu, so I think you are the most qualified to pull these in. They have the best implications for you since you can drop all that fallback code now too.
next prev parent reply other threads:[~2016-06-01 15:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 18:27 [PATCH v2 1/3] dell_rbu: Don't fallback to userhelper Mario Limonciello
2016-05-16 18:27 ` [PATCH v2 2/3] dell_rbu: Update documentation Mario Limonciello
2016-05-16 18:27 ` [PATCH v2 3/3] firmware_class: drop support for FW_LOADER_USER_HELPER_FALLBACK Mario Limonciello
2016-06-01 15:35 ` Mario_Limonciello [this message]
2016-06-02 2:24 ` [PATCH v2 1/3] dell_rbu: Don't fallback to userhelper Ming Lei
2016-06-02 2:33 ` Mario_Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=669ce00ff2ff4641b78ee048cb0693e0@ausx13mpc124.AMER.DELL.COM \
--to=mario_limonciello@dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).