From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: <julia.lawall@lip6.fr>, <qca_merez@qca.qualcomm.com>,
<kvalo@codeaurora.org>, <linux-wireless@vger.kernel.org>,
<wil6210@qca.qualcomm.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Bhumika Goyal <bhumirks@gmail.com>
Subject: Re: net: wireless: ath: wil6210: constify cfg80211_ops structures
Date: Thu, 12 Jan 2017 11:55:43 +0100 [thread overview]
Message-ID: <66ab58f4a83d4164ae06cbb27fb38904@euamsexm01a.eu.qualcomm.com> (raw)
In-Reply-To: <1482014667-27082-1-git-send-email-bhumirks@gmail.com>
Bhumika Goyal <bhumirks@gmail.com> wrote:
> cfg80211_ops structures are only passed as an argument to the function
> wiphy_new. This argument is of type const, so cfg80211_ops strutures
> having this property can be declared as const.
> Done using Coccinelle
>
> @r1 disable optional_qualifier @
> identifier i;
> position p;
> @@
> static struct cfg80211_ops i@p = {...};
>
> @ok1@
> identifier r1.i;
> position p;
> @@
> wiphy_new(&i@p,...)
>
> @bad@
> position p!={r1.p,ok1.p};
> identifier r1.i;
> @@
> i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> +const
> struct cfg80211_ops i;
>
> File size before:
> text data bss dec hex filename
> 18133 6632 0 24765 60bd wireless/ath/wil6210/cfg80211.o
>
> File size after:
> text data bss dec hex filename
> 18933 5832 0 24765 60bd wireless/ath/wil6210/cfg80211.o
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Patch applied to ath-next branch of ath.git, thanks.
b59eb96181e7 wil6210: constify cfg80211_ops structures
--
https://patchwork.kernel.org/patch/9479127/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2017-01-12 10:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-17 22:44 [PATCH] net: wireless: ath: wil6210: constify cfg80211_ops structures Bhumika Goyal
2016-12-30 13:01 ` Kalle Valo
2017-01-12 10:55 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66ab58f4a83d4164ae06cbb27fb38904@euamsexm01a.eu.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=bhumirks@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qca_merez@qca.qualcomm.com \
--cc=wil6210@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).