From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Colin King <colin.king@canonical.com>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>,
Bhumika Goyal <bhumirks@gmail.com>,
Michal Nazarewicz <mina86@mina86.com>,
linux-usb@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: udc: remove redundant initial assignments to the pointer 's'
Date: Tue, 28 Mar 2017 13:20:14 +0300 [thread overview]
Message-ID: <66ad4118-7c0a-06b9-b780-d0d613cb8152@cogentembedded.com> (raw)
In-Reply-To: <20170327223439.10063-1-colin.king@canonical.com>
Hello!
On 3/28/2017 1:34 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The initial setting of pointer s to the driver name or to the literal
> string "(none)" is redundant as later it is always set to point to
> a different literal string before it is printed log. Remove this
Printed to log, perhaps?
> redundant code.
>
> Detected with CoverityScan, CID#1227032, CID#1227033 ("Unused Value")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
[...]
MBR, Sergei
prev parent reply other threads:[~2017-03-28 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 22:34 [PATCH] usb: gadget: udc: remove redundant initial assignments to the pointer 's' Colin King
2017-03-27 23:37 ` YUAN Linyu
2017-03-28 10:20 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66ad4118-7c0a-06b9-b780-d0d613cb8152@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Linyu.Yuan@alcatel-sbell.com.cn \
--cc=balbi@kernel.org \
--cc=bhumirks@gmail.com \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).