From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05632C04AB7 for ; Tue, 14 May 2019 06:06:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CBE3D206A3 for ; Tue, 14 May 2019 06:06:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=landley-net.20150623.gappssmtp.com header.i=@landley-net.20150623.gappssmtp.com header.b="e91q8D7a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726216AbfENGGN (ORCPT ); Tue, 14 May 2019 02:06:13 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:42625 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725892AbfENGGN (ORCPT ); Tue, 14 May 2019 02:06:13 -0400 Received: by mail-ot1-f66.google.com with SMTP id f23so14113212otl.9 for ; Mon, 13 May 2019 23:06:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=landley-net.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PXt1KR8uTPyJUn4Yxy2apR4YARPk5L8lEm2vMkzJPBM=; b=e91q8D7aFphaY4A6IL5QmEU/FViV57G/ehUkaEkFrK1dcpjq0tV/orbAlirGH4/L0V HiNO6aGwsRRgCXa9Hh5CgGQmS+70E/uhKmZPWtXXVpGjcYHJ2hDsl0yyTFjkgTK/xlmx PhNiLFgJYZJwyvVHfroFvFD0FW7PSkb2EPJ0qQW74bWCcU2i2RSPzx/nzo6/Od7NLPJ+ Ond0PKkr+1PCB1r5YvqNf3Nfocj1tasDuWueMZIbWi966AHRCkQ2utNMgUMZndXBy68H g+ssB7URZ3eeNsnjb5ZvI8b2btqbFB0jfNIfgT8YzZ7FAnbWztIJtQChnH90RVS4ob7n Uq+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PXt1KR8uTPyJUn4Yxy2apR4YARPk5L8lEm2vMkzJPBM=; b=ZAODWYD+8m8l017cewFaLrrldWxkGVEWU0pHkYUO1NGDd9HHIivKRWUy1LMItepPu5 SZju1mNYXQgKkZCGpxLeQIpsjqupvfKFYqLVF/fMicqISVTUvkzkrnuhSc1dy3Lip7Ca JZ1hhLBJTC5OMNHTIdPUvibiXYFMmM7OY9a38HQbe+AJADlj/7nvJbymg5R4FHu7MGoc PeQyZAQ6p1NFItCcGshm2HXijml54lLBA3sBMABc7rlwlqQUksxHcCe+5QJWGI5dAVp9 VzdyeA5wOQ3mqennnM+5an57V7CzeX02clqWjxD8cocMNMY4npmXl1g7CcFRhzk7nFxN jtOw== X-Gm-Message-State: APjAAAUkCbK3LniyZwyRMh+DLgwFdJdUNS8omd5DPWl2DF6ouqw4/Mn6 66NdqWq1nqZxw9PqUOOo4FJqZw== X-Google-Smtp-Source: APXvYqz34cqK8ejkbSx+SrrTyV2DMUPTt7fPvQMKcNmaB8vAqawQFjp1e57tMQIaPu2wl3v6VjClBA== X-Received: by 2002:a9d:638f:: with SMTP id w15mr7650121otk.16.1557813972655; Mon, 13 May 2019 23:06:12 -0700 (PDT) Received: from [192.168.1.5] (072-182-052-210.res.spectrum.com. [72.182.52.210]) by smtp.googlemail.com with ESMTPSA id a1sm6771206oiy.38.2019.05.13.23.06.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 May 2019 23:06:12 -0700 (PDT) Subject: Re: [PATCH v2 0/3] initramfs: add support for xattrs in the initial ram disk To: Mimi Zohar , Arvind Sankar Cc: Arvind Sankar , Roberto Sassu , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-integrity@vger.kernel.org, initramfs@vger.kernel.org References: <20190512194322.GA71658@rani.riverdale.lan> <3fe0e74b-19ca-6081-3afe-e05921b1bfe6@huawei.com> <4f522e28-29c8-5930-5d90-e0086b503613@landley.net> <20190513172007.GA69717@rani.riverdale.lan> <20190513175250.GC69717@rani.riverdale.lan> <1557772584.4969.62.camel@linux.ibm.com> <20190513184744.GA12386@rani.riverdale.lan> <1557785351.4969.94.camel@linux.ibm.com> From: Rob Landley Message-ID: <66b57ae5-bb5a-c008-8490-2c90e050fc65@landley.net> Date: Tue, 14 May 2019 01:06:45 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1557785351.4969.94.camel@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/13/19 5:09 PM, Mimi Zohar wrote: >> Ok, but wouldn't my idea still work? Leave the default compiled-in >> policy set to not appraise initramfs. The embedded /init sets all the >> xattrs, changes the policy to appraise tmpfs, and then exec's the real >> init? Then everything except the embedded /init and the file with the >> xattrs will be appraised, and the embedded /init was verified as part of >> the kernel image signature. The only additional kernel change needed >> then is to add a config option to the kernel to disallow overwriting the >> embedded initramfs (or at least the embedded /init). > > Yes and no.  The current IMA design allows a builtin policy to be > specified on the boot command line ("ima_policy="), so that it exists > from boot, and allows it to be replaced once with a custom policy. >  After that, assuming that CONFIG_IMA_WRITE_POLICY is configured, > additional rules may be appended.  As your embedded /init solution > already replaces the builtin policy, the IMA policy couldn't currently > be replaced a second time with a custom policy based on LSM labels. So your design assumption you're changing other code to work around in that instance is the policy can only be replaced once rather than having a "finalize" option when it's set, making it immutable from then on. Rob