From: Paolo Abeni <pabeni@redhat.com>
To: syzbot <syzbot+a4aee3f42d7584d76761@syzkaller.appspotmail.com>,
davem@davemloft.net, johannes@sipsolutions.net,
kvalo@codeaurora.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: WARNING in hwsim_new_radio_nl
Date: Tue, 14 Apr 2020 12:42:17 +0200 [thread overview]
Message-ID: <66c3db9b1978a384246c729034a934cc558b75a6.camel@redhat.com> (raw)
In-Reply-To: <000000000000bb471d05a2f246d7@google.com>
#syz test git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master
I don't see why the bisection pointed to the MPTCP commit ?!? the
following patch should address the issue.
---
diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c
index 7fe8207db6ae..2082abdb08d4 100644
--- a/drivers/net/wireless/mac80211_hwsim.c
+++ b/drivers/net/wireless/mac80211_hwsim.c
@@ -635,7 +635,8 @@ static const struct nla_policy hwsim_genl_policy[HWSIM_ATTR_MAX + 1] = {
[HWSIM_ATTR_SUPPORT_P2P_DEVICE] = { .type = NLA_FLAG },
[HWSIM_ATTR_USE_CHANCTX] = { .type = NLA_FLAG },
[HWSIM_ATTR_DESTROY_RADIO_ON_CLOSE] = { .type = NLA_FLAG },
- [HWSIM_ATTR_RADIO_NAME] = { .type = NLA_STRING },
+ [HWSIM_ATTR_RADIO_NAME] = { .type = NLA_STRING,
+ .len = NL80211_WIPHY_NAME_MAXLEN },
[HWSIM_ATTR_NO_VIF] = { .type = NLA_FLAG },
[HWSIM_ATTR_FREQ] = { .type = NLA_U32 },
[HWSIM_ATTR_TX_INFO_FLAGS] = { .type = NLA_BINARY },
next prev parent reply other threads:[~2020-04-14 10:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 16:32 WARNING in hwsim_new_radio_nl syzbot
2020-04-13 6:15 ` syzbot
2020-04-13 14:05 ` syzbot
2020-04-14 10:38 ` Johannes Berg
2020-04-15 15:16 ` Dmitry Vyukov
2020-04-14 10:42 ` Paolo Abeni [this message]
2020-04-14 10:59 ` syzbot
2020-04-14 11:11 ` Johannes Berg
2020-04-14 12:55 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66c3db9b1978a384246c729034a934cc558b75a6.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+a4aee3f42d7584d76761@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).