From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755511AbcHBUka (ORCPT ); Tue, 2 Aug 2016 16:40:30 -0400 Received: from mail-by2nam03on0047.outbound.protection.outlook.com ([104.47.42.47]:2368 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751785AbcHBUkN (ORCPT ); Tue, 2 Aug 2016 16:40:13 -0400 Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; goodmis.org; dkim=none (message not signed) header.d=none;goodmis.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160c69-5dfff70000000bcb-c0-57a0fae168e1 Subject: Re: [PATCH 0269/1285] Replace numeric parameter like 0444 with macro To: Steven Rostedt References: <20160802105508.31682-1-baolex.ni@intel.com> <20160802193006.GB6066@home.goodmis.org> CC: Baole Ni , "linux-kernel@vger.kernel.org" , "chuansheng.liu@intel.com" From: Bart Van Assche Message-ID: <66ddf2c0-c8b3-8798-761b-e5edb04d3ecc@sandisk.com> Date: Tue, 2 Aug 2016 13:04:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <20160802193006.GB6066@home.goodmis.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFLMWRmVeSWpSXmKPExsWyRoxnke6TXwvCDZoeylmceXKU3WL6l33M Fpd3zWGz2NfxgMmBxaNl3y12j8V7XjJ5fN4kF8AcxWWTkpqTWZZapG+XwJWxeu5b9oIzzBU3 fj9ia2B8ydTFyMEhIWAiseixRBcjF4eQwFImiaebdrBAONsZJa4eOg3kcIIVLV20kAmqilFi xeLNbCAJYQFfiakrzzKC2CICGhItC55Ddc9glFh+9zCYwywwh1Hi6JWzzCBVbAJGEt/ez2QB 2c0rYCex9gYTSJhFQEXi9swNYLaoQJjEtLtv2UFsXgFBiZMzn4BdwSlgKnH49RRWEJtZwEJi 5vzzjBC2vMT2t3OYQXZJCCxjlXjz7AZYkZCAusTJJfOZJjAKz0IyaxaS/llI+hcwMq9iFMvN zCnOTU8tMDTVK07MS8ksztZLzs/dxAiJgcwdjHefeB9iFOBgVOLhfXBmQbgQa2JZcWXuIUYJ DmYlEd6230Ah3pTEyqrUovz4otKc1OJDjNIcLErivG73voQJCaQnlqRmp6YWpBbBZJk4OKUa GFP/FS7lP9705ZbR0yVxC6YoXAtP5d4weZNp3h4Ndo4fwo96la9oLtmne/V2RshLK7PIXw/n pFu3flxipH8uReJj4J6wou4nCq/jv78qWM035WCZmVHuyufatcvsl11zunBzx+6G7Bnrjt2N lnQNKe00evHcaqVqcvTThIYWBu7eHSLVs7OPn1JiKc5INNRiLipOBAB9JqRCfQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPJMWRmVeSWpSXmKPExsXCtZEjRXfjnwXhBu/u2FiceXKU3WL6l33M Fpd3zWGz2NfxgMmBxaNl3y12j8V7XjJ5fN4kF8AcxWWTkpqTWZZapG+XwJWxeu5b9oIzzBU3 fj9ia2B8ydTFyMkhIWAisXTRQjBbSGAxo8S/d4YgtrCAr8TUlWcZQWwRAQ2JlgXPWboYuYBq ZjBKLL97GMxhFpgD1PDzIzNIFZuAkcS39zOBEhwcvAJ2EmtvgA1lEVCRuD1zA5gtKhAmMe3u W3YQm1dAUOLkzCcsIDangKnE4ddTWEFsZgEziXmbHzJD2PIS29/OYZ7AyDcLScssJGWzkJQt YGRexSiWm5lTnJueWWBopFecmJeSWZytl5yfu4kRHIScUTsYr080P8TIxMEp1cCo+dyjs8r6 xsWujzfyimzM3z9e8da+e4ujp6CkzFl74arXgtcYxJk0e8xfCfadVdt9y46T7+CU2+7TD3i/ d8nYdfabs+aM2icTp2ofUffsvhKkJ365xFu9V/HG5MteWVPnLLx6z29tm+LNqZVnpBp2ZNr9 tYjpWsvQbTe78j9PtIDiNA17SSclluKMREMt5qLiRAAILn8a8gEAAA== X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:63.163.107.21;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(979002)(6009001)(7916002)(2980300002)(438002)(199003)(69234005)(189002)(377454003)(24454002)(31686004)(64126003)(53416004)(92566002)(11100500001)(230700001)(106466001)(586003)(81166006)(81156014)(87936001)(8676002)(86362001)(305945005)(8936002)(7696003)(4326007)(50466002)(77096005)(2950100001)(69596002)(31696002)(7846002)(76176999)(23676002)(65956001)(2906002)(50986999)(189998001)(356003)(33646002)(36756003)(2270400002)(83506001)(68736007)(47776003)(97736004)(4001350100001)(65806001)(54356999)(110136002)(65826006)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR02MB1301;H:milsmgep15.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD041;1:13KW/jvbDPld+S09q3HK12+1TejyrbzNdPt+NnuJmWROESuO1f+v+FIvdB+KIabnL9F3AukfHSPlqVXjMJ+HsJiPDMhkwIAt05jthaP54wUrH7aQH+yb6gBYrVp3s+m5FmXC7+eZWGo9oClYYmzQu+/xUcZ4dvG8QWNRv+/7V9RZz/d0MNunX6u/AX8D1ksO/K2GBPvfO0sjqUNrOSSmxNzYbhxVNpZj8+/Q6+4MTp5BM2EfTvD+xnzfM2hQ4aOI2mSSN5nKFlAq5Utb4CmMkKTng3f6e17uBnatsuTKP/E7ob2aK7Lql1gycV5VMBXClUtxlzlLSmjJTq1Q8pmrRRW2ZgI91kK1YDRwS68jiDggyu+HAFi+Au6mfM+ZxgZXR0fCy1tyiI/r7ih1gnHQIL7g+ZeUlK2IpbeqpabrsYxJ77ptPd2vcnwWTiIM23QVDdzSGO36XDFgsmmcyQ2WXEHEbgjzOnPJNFo3nvM7qUex8IKzvX6sVovnV+t3GuIpqntqIlFy4b0WVWurgltksQ== X-MS-Office365-Filtering-Correlation-Id: b2c5044c-bcaf-478f-3586-08d3bb102892 X-Microsoft-Exchange-Diagnostics: 1;CY1PR02MB1301;2:JIP8Dkv6qG0LKhUkVuCAkKsK93uwoczkrlJ4lln4UE9Tib9HJAt6YwD5Bq3vu8vgqU54naGJsHmjV4uKc+rt/nBhXi3f7Dr/O0rz+A8LWSkjBLqxxs1Dc7+pyKkj1u+hb/sTh+xgdFRxzoKCB1/MwN7m307kk3y4X1peQd1wHejv6KpeICEUChqwH720LrUo;3:YJaaoeGdFJIBXHnH6tEpcK6ojWVy/8/3Ve/bQisA3MoJaw8cwASH3CWDzpaZKCbwIlBVVnnfFWVKCcXgCmOzylNMmmRioS1rm4woud80BRffAIeUyb+KaB1DCk7WneuJnSNWS71SZXThEAe3RPWehXiNPP3tVtGSWLejnn2pwRGaNxEeEnEsPIHCkoYOSefvNfsTZSGvXKdD1we4Q3eYDNgWnySo4mwjjmZARNp7tGWQgVslS95OTj3y32mbI8ulZO5wQIM49PvOIJ6d8q0+4Q== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:CY1PR02MB1301; X-Microsoft-Exchange-Diagnostics: 1;CY1PR02MB1301;25:0E/5J5pxK6TdF3Q1e5g9OPxtuW0wYqR7X6wveSZ/gRdEQ0sxG5B6KCxukxbGwN9imqEO2rYLjixZZCUAzRnUSyPeEMzP75CdUCGceDmvBcq6LoxbQBK4hpGatX6DHcsylVp4+H15HBk/c61ZrjZ9Y1xA7RgfHX/gG8IpRTWsWAtNhSIS0lUPUSdNBacLXsbtW2aofuUwU1hJiRAnfap2QJ9Q8a0/sv1zgdgg3k+jwqyVFZ3J7QtVTIWoDFQtuwsRzltUL6da9LXaloLzRgU8UbXwfPoelQYgKAxySgOqcBu//mO2v/ZDW+mJzUCg8xft8TZzqUkrodB0P+SlOXiAeY+zZQwmrO2LBQiuSrktZv0+pzdt89MNYXDZBqqmwLIqlfkFiHVLjrmsFOOSbzODKBpZ0AsBqkqGlcKFbQgQOfgjmPj5Blpwr5C9JWD0Mhle0/aiR7G+qWnZC0ABAm1u+C8O+9WxWIcxeA3qgNlmP+nT4qicSnDe2IF+sO/bPyHykfaVikA0ASZ8wJohWfTUmyQZOlgLMCB4RfBZlED2+GYg3kZmqdcZaNJoIiOXE/YYK+tDvZTyofwfw61bqmsgxks3IfYj41lKQSmGnQdxhVbBoXW9GF+M96ntJ6k0h5Y2nXlgEe9hA3jW6veT/bBTbHMll/kidCrhcPAQ9Qwnq1axH7czvthrh4twq38Jgo7WWR1SXAGtBtT+rpBHFEs0S9BcaEsuMXTJrLAmcvN84FRfv7wPyMQnll6cmh5BPxDRO9vrtYsDIcIoKtllsuod6A== X-Microsoft-Exchange-Diagnostics: 1;CY1PR02MB1301;31:K03+qs0yyvEEB9OkBkC9qZDYTDw+Q0VHJMCEopfhSbRBnm7rDzfMN16QkkGEWSQNzDVRU+wCVG8Y8HksICUbro/IAIT/aAOZHk5DlMOIcLbTns9NXp1eQG/SXFGnSR/YqnD2H9Dsqmp3vMT/6ir2aIVgXptT0o0ypf/tobPVF9MJLf7C8ieWdrPSvWrBva3XmWaalj62qrVoA9UaHX/OD92S/zNheBGsntttnRT0xb0=;20:vut748glaFJq/pLlFLR6vZt9UR05dQjWeeLm4CFiSO/f8cT2EBHjAu7cBP/Kaw8dAQ0xqpQ7KwzEHSiWRp1ee95OFpJ9oqfQnruOma8GV5S4jGORWxjYmPgAhnnLpYfmskfmMp42VfDwN59L4aSZFCfsRyYeEQw17QMMscLgR0vNGV5lDZH4LXaCRKZQchNvi+1MjcyIy6RkNUCldw8+lRVD6cqJow5lIXrb1rDHJRl9KuuyzKXMg7pcbN43+cAexN9+6wvEScOBHduTc1bEDe/gJ3esQLMYekCUd+H6+kFDbSWTybmuxSQT2c+1224lavq/wpdIR7/BD0HbP09pKMLnFFGudCVcX5jd0NqMPUDYWUmX1dBcNHRV31z895UE9GPm6zLccUNarpgPTsnw8tdmUEVMlBScJh3ijbNZWNKRg/QBMDfY+KfH/c5szTv8j3FN2KWjO8a2gMLBaw4iFNul7dRl+mfVInk9tvKmSnSyMDsog98NaI94ffzzkvxT X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13018025)(13016025)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:CY1PR02MB1301;BCL:0;PCL:0;RULEID:;SRVR:CY1PR02MB1301; X-Microsoft-Exchange-Diagnostics: 1;CY1PR02MB1301;4:fMt+h/BkXdEIZegszYP75aZie+GenV0vMxnD4dZ7PXH+CcnB6CmR6avPZRcwGNg3xeI6Iv8XvtYZBODZiP7lo5iBkh0k7bHA4VQHgp1QjADDSkxETTeXUzpPCgAoRnG1d0/+ix/1KV1Mywx0Lt9QKs9WgrFm1wJTlHvkCq9VErPrzrLVw1Be7KxS/ldiH7KpgqAMwmiZsf/Y6/RWkEAL+c8hmyoEYb/0hngAxYYcmWyrIS8Fx2HvpWtNsaWBxQLFsb7kw/7695p2u8unw0DMatvla26tzG41ilsZYi/8UJNylfvkDRNNe5xzbaA6MxJ2MGOUetljZJLHXX7Ra9wVDzgIS4P0+idGmOejsL8lmH0autoTPzAZsqIedwt9Luat+k1ZBeRw0ZF7bn5SkIXmyrfhmoWChr4L0n5GUDnxZHhwkNahRflEE2ZxBEKmeLQmqJMCrjSAST2JncEkL99NBA== X-Forefront-PRVS: 0022134A87 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAyTUIxMzAxOzIzOmxmbXRSTHE0UVMrODVTZzNIbnVTUUNhOUtn?= =?utf-8?B?TW5qK1JlVStVU1ZMNDFSYVVtYUNuM0h4VzRBZ1FjYSt2RUpBRjZyNy8yN3Yw?= =?utf-8?B?SXZYcDNjZk5xNDZhU3MyZDFDTGtubzNJU1IxcHFPM3Frc0QrTG9qRGpuV1lF?= =?utf-8?B?b1VvcTR4cGdPR0pNbTk4NWZSSGNpdTlRc092c1Z2dytUTXR5eG5YUytDSk1Q?= =?utf-8?B?UmpUSTlLYVUzeGszNDBZaXYrSkR6clZhN09WZ1I5eE9QbUlPNE9tOEdaU0xG?= =?utf-8?B?QlBJU0R2bmFvWkJmSitZQTZrT3ZRRThTRjNkeW1RbkJQYmJqTzFXUWZNRXFl?= =?utf-8?B?Wm1hSWpEbFQxelg2d1RMMUFRMjY5MXRvZm1vRGh5S2IrU3BBOWRkMkNOYThy?= =?utf-8?B?MWc5OS9rTnUyQjVvYTA4U2pYSnppR0hqK09PSHZ0NHBCWDA0RGExdUlGajVl?= =?utf-8?B?ZTBDOFU0OWhtU2sxZ1o5eTA4N2NZYlpPc2M1Q2hPeS9xWnQzTldNcVJrMFJD?= =?utf-8?B?ZmNuRkh1bG1UZTNWVkYyRW1YcG4rMlpOWElzdXpRSVc2ZGVUOFh0dTgwZ0FP?= =?utf-8?B?dGgxTmxrSWVFeWFNN0ozSnlwL1lPS3d5aU54dlVqdU1qUnh2LzJPc3FVN0Fl?= =?utf-8?B?dk0yK29CMWpZelFHcGhPUjcyNVZyRUV2Y0lpQWlPRVJSQVZYQmdaNHh3ckx0?= =?utf-8?B?ZTVGS0swVVI2REFSTEc0Y3RqcitYM2x6b0k5aFBDdDEyZXFNQWFDU2JVVlZw?= =?utf-8?B?NlVONVNUUkdFV0RTd21URjVPQlB4OGNIK3gvTnRSSE5MWDljWEtKN1RKeXNm?= =?utf-8?B?QlYzZGJaWnBkY0ZmclRTOXJBYktlUkdKSnhlcDh0L0dORVUrZ3d4UDZ0TDIx?= =?utf-8?B?QkFPaUNmVnExNUFQY0lTeUJ0WkY3Ymg5UTQySmJkNW1BTlRxa0l1dlhjNHhI?= =?utf-8?B?QTJlUG15R2hDRW96dlRxcS90azNoRTFMbU5lUHlIZ09rTEhYRzF3cGc1ZGZk?= =?utf-8?B?dzhzb294S0RMYnZid0toQUpQOURZekFSYlFOUnJicm5SVFNxUWhqcGYyTkw0?= =?utf-8?B?bkNwN1Qyc3FiV2NoL1l6OExnbmtLUWJ3VVdkbWd5dS9iaThSbnpmZDFEc2la?= =?utf-8?B?cUIvNTlrbmJRcEExODdIaXdveWpqNTdRVGhLUWVMbUhwMEJ1NS81Wkl5SlBK?= =?utf-8?B?K0hXMXlIUjIyc1YvaWowcFowL1VpN1ZhbHg3OVVNcXRDNW5DZkswNVd2WnYw?= =?utf-8?B?WWt5Unl1NEsrUzNOUDBJL0ZRRUU3NXZ2cEtub0xGMzVGYjJ5QVRycStSRWp2?= =?utf-8?B?MUtpMklDU0IxblVoLzRGT3Bta1pDYjZ1Q2p4cHQ5WCtBOHU1ckNLVGhDUVMy?= =?utf-8?B?Qk8rcCt5UURKTEM1dFhYa21Ha256RHhXSmJ6YytQcFl0bVJ0NlJJbVRSaXFy?= =?utf-8?B?NUpPTmJYU0grdFNQcWcxcERGNVZPUlpydTBzSmRJZWp2bmVrbnFwa2tQY0dK?= =?utf-8?B?WGpBT3NEOThpVGJDQlZENllHbG1sRlF0NC9pMkNVeUFSRW95RTNFTTdBR2tL?= =?utf-8?B?M1hxa0FtMFJSeU9yci9ORGh2cVluMjlXL3RqaXNwblZMNWF4cjlnbis5ZXUv?= =?utf-8?B?RWdLRU1tdmdvQ3dMZE9VNlUwZlpyRS94OWF5SHI5em8vODErTUFDQXFNZEU0?= =?utf-8?B?ejNsWXVFMmE4MU12eTdHN2pwOGpVN3FmbVlNclJici83aDRGMjdjSDAzbTlx?= =?utf-8?Q?WzlnBfeEMgTXzMVyIKzWnp4z+/+gnLO394Uv4=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR02MB1301;6:vI3Gl+OP8kFeoBRHvcuvdq0knLrz327KCL2aSkPo92xpyOAWl0aL8uDNPius/zI+e0I0XYNtPiE6G8WSSVUeyQumhhe/ZbKsH4d9BgQt8wfu6WJ+eRJ0Q1jessrCwjad1GFDYI6J8uskdDr97COXYyOaCstVtbOfMh1zFWt+R/uOPXM/GbBmQeIZP2ih5bt5F+6hdknj9AJiAzIijXPiARSd1qWghcqaN1NcnD63jIz3xPLJXZ8w0gmZrWGYaCuJzUtHUTtkShh6jWSO9YzT76rIl0cPIiQh7VIq6GOaomAZgCNa3y3UJlMLDaMpVLDqLh7oVZQ3MyXkeqy9foWB8Q==;5:Sb82/pEltsTb9oo/nmfxdyu58few2eMgbvC1QjKiolNoOEAVR4sHDEjItVWQEvhP8IFrUzqjZPvt9fXpVKX1UYEQ5ctmV/8LfJYgJcrYaj+iWDN00rit35/boOYlwm6Xp2hmDK+cBt2LeuuzxQklng==;24:smBZdmk5r7CgavrxK1wS4T0gfa2/ICMXdz9mV4enRcX0kI9wHfbQgfYNrAWYnmaIxSkrz71Yc5SqwnWZjGpEDRjcmF37Pjue8xYAj+q1v8s=;7:YEetgZUl0CYov7vpk0OP+W5XYiLqOb0lF1X7/2hdo7eaJacF7PI4+bNmbcWEFN2MtlEzjh9zzkgQAMt7/TBo/UJ7NahwgG9uMLnUzYFtlQn+rFj9arUMwk4BgOnxF+OuEgK87bI8+VydUXNOw3RzNMnP2Vv6nNQc5HFjb0pxnUWo1v5kz8Cku4NjhinSlAb3tF/yWlcHJWStUXl7fW80d9ma4gROVOhzDqyLnIUVBHq5MxathxbSDNb+MyGPetdc SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR02MB1301;20:Wfk4QFlKZKrqAW4Ng7oe+BDgYJEJfwx1SSK1hvCct+z4vHdzYo84crji76gONP/x2osr86cfZlCgs/Gb2DSET2VkrqNPmlFetWDVL4LNBSTRanffjaAkuzA7XS8MrHZP53Nc4GRVZi5ksZuKOjHYiFNUZP7Y2P01foQqApSvZj5O5iOqNWAIkzN0otDKqb38OjTF1Yj9CqJ7KgAQmPxALTK2ijDzVd31pv40L7HL7R/k+VeZz5TVI82hbkaD/nVd X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2016 20:04:05.8765 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.21];Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR02MB1301 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/02/2016 12:30 PM, Steven Rostedt wrote: > [ removed most the Cc list ] > On Tue, Aug 02, 2016 at 08:14:10AM -0700, Bart Van Assche wrote: >> Please change 0444 into S_IRUGO and 0644 into S_IRUGO | S_IWUSR. The latter >> form is more compact and hence makes the code easier to read. > > FYI, Linus already NACKed the entire thread. Hello Steven, Thanks for letting me know. I didn't consider these patches as very valuable anyway. Bart.