From: Adrian Hunter <adrian.hunter@intel.com>
To: Baolin Wang <baolin.wang@linaro.org>,
ulf.hansson@linaro.org, zhang.lyra@gmail.com,
orsonzhai@gmail.com
Cc: vincent.guittot@linaro.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] mmc: host: sdhci-sprd: Fix the incorrect soft reset operation when runtime resuming
Date: Wed, 17 Jul 2019 09:07:05 +0300 [thread overview]
Message-ID: <66eb3053-ca2d-e2f0-edf0-9227f75a5693@intel.com> (raw)
In-Reply-To: <89c3ef495c367d58ca3abe99a1f82c48f8c08705.1563274904.git.baolin.wang@linaro.org>
On 17/07/19 5:28 AM, Baolin Wang wrote:
> In sdhci_runtime_resume_host() function, we will always do software reset
> for all, which will cause Spreadtrum host controller work abnormally after
> resuming.
>
> Thus for Spreadtrum platform that will not power down the SD/eMMC card during
> runtime suspend, we should not do software reset for all. To fix this
> issue, adding a specific reset operation that adds one condition to validate
> the power mode to decide if we can do software reset for all or just reset
> command and data lines.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> Changess from v3:
> - Use ios.power_mode to validate if the card is power down or not.
>
> Changes from v2:
> - Simplify the sdhci_sprd_reset() by issuing sdhci_reset().
>
> Changes from v1:
> - Add a specific reset operation instead of changing the core to avoid
> affecting other hardware.
> ---
> drivers/mmc/host/sdhci-sprd.c | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index 603a5d9..94f9726 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -373,6 +373,23 @@ static unsigned int sdhci_sprd_get_max_timeout_count(struct sdhci_host *host)
> return 1 << 31;
> }
>
> +static void sdhci_sprd_reset(struct sdhci_host *host, u8 mask)
> +{
> + struct mmc_host *mmc = host->mmc;
> +
> + /*
> + * When try to reset controller after runtime suspend, we should not
> + * reset for all if the SD/eMMC card is not power down, just reset
> + * command and data lines instead. Otherwise will meet some strange
> + * behaviors for Spreadtrum host controller.
> + */
> + if (host->runtime_suspended && (mask & SDHCI_RESET_ALL) &&
> + mmc->ios.power_mode == MMC_POWER_ON)
> + mask = SDHCI_RESET_CMD | SDHCI_RESET_DATA;
> +
> + sdhci_reset(host, mask);
> +}
> +
> static struct sdhci_ops sdhci_sprd_ops = {
> .read_l = sdhci_sprd_readl,
> .write_l = sdhci_sprd_writel,
> @@ -381,7 +398,7 @@ static unsigned int sdhci_sprd_get_max_timeout_count(struct sdhci_host *host)
> .get_max_clock = sdhci_sprd_get_max_clock,
> .get_min_clock = sdhci_sprd_get_min_clock,
> .set_bus_width = sdhci_set_bus_width,
> - .reset = sdhci_reset,
> + .reset = sdhci_sprd_reset,
> .set_uhs_signaling = sdhci_sprd_set_uhs_signaling,
> .hw_reset = sdhci_sprd_hw_reset,
> .get_max_timeout_count = sdhci_sprd_get_max_timeout_count,
>
next prev parent reply other threads:[~2019-07-17 6:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 2:28 [PATCH v4] mmc: host: sdhci-sprd: Fix the incorrect soft reset operation when runtime resuming Baolin Wang
2019-07-17 6:07 ` Adrian Hunter [this message]
2019-07-22 11:54 ` Ulf Hansson
2019-07-23 3:05 ` Baolin Wang
2019-07-23 3:21 ` Chunyan Zhang
2019-07-23 3:30 ` Baolin Wang
2019-07-23 12:38 ` Ulf Hansson
2019-07-24 2:21 ` Baolin Wang
2019-07-24 12:55 ` Adrian Hunter
2019-07-25 3:05 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66eb3053-ca2d-e2f0-edf0-9227f75a5693@intel.com \
--to=adrian.hunter@intel.com \
--cc=baolin.wang@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).