From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFDD4C43381 for ; Mon, 1 Mar 2021 12:09:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9284464E40 for ; Mon, 1 Mar 2021 12:09:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232916AbhCAMJV (ORCPT ); Mon, 1 Mar 2021 07:09:21 -0500 Received: from mga12.intel.com ([192.55.52.136]:45440 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232806AbhCAMJQ (ORCPT ); Mon, 1 Mar 2021 07:09:16 -0500 IronPort-SDR: eJYIWi8s7yqcreM+DdFJW/oj1gy6OJFeM1evRzN7rFD49ki43uH6giuKs44x9U3vuHe9ZEGjOp gQxRGl3xhzfw== X-IronPort-AV: E=McAfee;i="6000,8403,9909"; a="165674457" X-IronPort-AV: E=Sophos;i="5.81,215,1610438400"; d="scan'208";a="165674457" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2021 04:08:31 -0800 IronPort-SDR: x2LYCeO81ERh0Y8qbWt3KswwfQRQelD3R1rr4l0w2buEGtLkjAAWeL1Y+Z/2MvazMKFsxHDYuV jdMLjzJU5PFg== X-IronPort-AV: E=Sophos;i="5.81,215,1610438400"; d="scan'208";a="368580584" Received: from sanand-mobl.amr.corp.intel.com ([10.251.13.183]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2021 04:08:27 -0800 Message-ID: <66f1f4e39de4314f9c1b7a6d7cd6914e42a20217.camel@intel.com> Subject: Re: [PATCH 02/25] x86/cpufeatures: Add SGX1 and SGX2 sub-features From: Kai Huang To: Borislav Petkov Cc: kvm@vger.kernel.org, x86@kernel.org, linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, seanjc@google.com, jarkko@kernel.org, luto@kernel.org, dave.hansen@intel.com, rick.p.edgecombe@intel.com, haitao.huang@intel.com, pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com Date: Tue, 02 Mar 2021 01:08:25 +1300 In-Reply-To: <20210301115854.GE6699@zn.tnic> References: <20210301100037.GA6699@zn.tnic> <3fce1dd2abd42597bde7ae9496bde7b9596b2797.camel@intel.com> <20210301103043.GB6699@zn.tnic> <7603ef673997b6674f785d333a4f263c749d2cf3.camel@intel.com> <20210301105346.GC6699@zn.tnic> <20210301113257.GD6699@zn.tnic> <0adc41774945bf9d6e6a72a93b83c80aa8c59544.camel@intel.com> <20210301115854.GE6699@zn.tnic> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2021-03-01 at 12:58 +0100, Borislav Petkov wrote: > On Tue, Mar 02, 2021 at 12:43:06AM +1300, Kai Huang wrote: > > To confirm, if we suppress both "sgx1" and "sgx2" in /proc/cpuinfo, we > > don't need to add "why to suppress" in commit message, right? > > You should always explain in a patch why you're doing the change. So > that a reviewer knows. And then people in the future can follow why > you've made that decision. Always. Got it. Thanks.