From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C136BC43331 for ; Mon, 11 Nov 2019 03:36:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 910C2206DF for ; Mon, 11 Nov 2019 03:36:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="eRv4wHEj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726965AbfKKDg6 (ORCPT ); Sun, 10 Nov 2019 22:36:58 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:54222 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726742AbfKKDg6 (ORCPT ); Sun, 10 Nov 2019 22:36:58 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id xAB3abTv129761; Sun, 10 Nov 2019 21:36:37 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1573443397; bh=NGl+cjCsJiM7+yT+llqpQfLL+t0dbhH4tKRXyQlZxFw=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=eRv4wHEjc1UMBodvQhvEME/+xNSPrDEWxqUQk+Bx3eHbzo5anuwt9WKRN1TQ8ibgN dzR9rhp5ePYMHT1zSfPrAE0RY10ZAsCps22mcIlPlkOptnQY7Y1FYnCPz3io3PVV83 B6XEc7zL0ArYYiQU0v6CuqNPPIEKMoXCIj7rXx6U= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id xAB3aaYP114012 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 10 Nov 2019 21:36:36 -0600 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Sun, 10 Nov 2019 21:36:19 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Sun, 10 Nov 2019 21:36:19 -0600 Received: from [172.24.190.117] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id xAB3aXhA043092; Sun, 10 Nov 2019 21:36:33 -0600 Subject: Re: [PATCH] irqchip/ti-sci-inta: Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)) To: Markus Elfring , , Jason Cooper , Marc Zyngier , Nishanth Menon , Santosh Shilimkar , Tero Kristo , Thomas Gleixner CC: LKML , References: <776b7135-26af-df7d-c3a9-4339f7bf1f15@web.de> From: Lokesh Vutla Message-ID: <670cd9a2-2083-bb5e-7bfc-58d5c90ec756@ti.com> Date: Mon, 11 Nov 2019 09:05:39 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <776b7135-26af-df7d-c3a9-4339f7bf1f15@web.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/19 5:00 PM, Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 5 Nov 2019 12:19:39 +0100 > > A coccicheck run provided information like the following. > > drivers/irqchip/irq-ti-sci-inta.c:250:9-16: WARNING: ERR_CAST can be used > with vint_desc. > > Generated by: scripts/coccinelle/api/err_cast.cocci > > Thus adjust the exception handling in one if branch. > > Fixes: 9f1463b86c13277d0bd88d5ee359577ef40f4da7 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver") Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver") With this: Reviewed-by: Lokesh Vutla Thanks and regards, Lokesh > Signed-off-by: Markus Elfring > --- > drivers/irqchip/irq-ti-sci-inta.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c > index ef4d625d2d80..8f6e6b08eadf 100644 > --- a/drivers/irqchip/irq-ti-sci-inta.c > +++ b/drivers/irqchip/irq-ti-sci-inta.c > @@ -246,8 +246,8 @@ static struct ti_sci_inta_event_desc *ti_sci_inta_alloc_irq(struct irq_domain *d > /* No free bits available. Allocate a new vint */ > vint_desc = ti_sci_inta_alloc_parent_irq(domain); > if (IS_ERR(vint_desc)) { > - mutex_unlock(&inta->vint_mutex); > - return ERR_PTR(PTR_ERR(vint_desc)); > + event_desc = ERR_CAST(vint_desc); > + goto unlock; > } > > free_bit = find_first_zero_bit(vint_desc->event_map, > @@ -259,6 +259,7 @@ static struct ti_sci_inta_event_desc *ti_sci_inta_alloc_irq(struct irq_domain *d > if (IS_ERR(event_desc)) > clear_bit(free_bit, vint_desc->event_map); > > +unlock: > mutex_unlock(&inta->vint_mutex); > return event_desc; > } > -- > 2.23.0 >