linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	David <davem@davemloft.net>, Guenter Roeck <linux@roeck-us.net>,
	Andrew Lunn <andrew@lunn.ch>,
	kernel <kernel@savoirfairelinux.com>
Subject: Re: [PATCH 1/3] net: dsa: introduce module_switch_driver macro
Date: Sat, 2 May 2015 14:47:23 -0400 (EDT)	[thread overview]
Message-ID: <671088801.177214.1430592443529.JavaMail.zimbra@savoirfairelinux.com> (raw)
In-Reply-To: <55440D7D.4060504@gmail.com>

Hi Florian,

>> This commit introduces a new module_switch_driver macro, similar to
>> module_platform_driver and such, to reduce boilerplate when declaring
>> DSA switch drivers.
>>
>> In order to use the module_driver macro, register_switch_driver needed
>> to be changed to return an int instead of void, so make it return 0.
>
> Do we get much benefit from having this change, the diffstat looks
> pretty neutral, ultimately register_switch_driver() might be gone (see:
> http://www.spinics.net/lists/netdev/msg326900.html) and mv88e6xxx cannot
> be converted to it due to how it is designed. This is not a strong
> objection though, the changes look fine to me.

Indeed, I initially introduce the macro for that purpose, I have an RFC ready
to remove the mv88e6xxx module and expose its functions, since it'd better be a
library instead of a driver.

I'll attach it here as a reply to give an idea of what it looks like and 
get feedback from you.

Thanks,
-v

  reply	other threads:[~2015-05-02 18:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-01 22:09 [PATCH 1/3] net: dsa: introduce module_switch_driver macro Vivien Didelot
2015-05-01 22:09 ` [PATCH 2/3] net: dsa: sf2: use module_switch_driver Vivien Didelot
2015-05-01 22:09 ` [PATCH 3/3] net: dsa: mv88e6060: " Vivien Didelot
2015-05-01 23:34 ` [PATCH 1/3] net: dsa: introduce module_switch_driver macro Florian Fainelli
2015-05-02 18:47   ` Vivien Didelot [this message]
2015-05-02 19:00     ` Vivien Didelot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=671088801.177214.1430592443529.JavaMail.zimbra@savoirfairelinux.com \
    --to=vivien.didelot@savoirfairelinux.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@savoirfairelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).