From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
To: Yong Wu <yong.wu@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Joerg Roedel <joro@8bytes.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
David Airlie <airlied@linux.ie>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Evan Green <evgreen@chromium.org>,
Robin Murphy <robin.murphy@arm.com>,
Tomasz Figa <tfiga@chromium.org>,
Will Deacon <will.deacon@arm.com>,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, youlin.pei@mediatek.com,
Nicolas Boichat <drinkcat@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
anan.sun@mediatek.com, ming-fan.chen@mediatek.com,
yi.kuo@mediatek.com, acourbot@chromium.org,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
Daniel Vetter <daniel@ffwll.ch>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Xia Jiang <xia.jiang@mediatek.com>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Eizan Miyamoto <eizan@chromium.org>,
anthony.huang@mediatek.com
Subject: Re: [PATCH v6 00/11] Clean up "mediatek,larb"
Date: Wed, 14 Jul 2021 10:56:20 +0200 [thread overview]
Message-ID: <672ef386-aa95-da45-0f17-acb398a1f6e0@collabora.com> (raw)
In-Reply-To: <20210714025626.5528-1-yong.wu@mediatek.com>
Hi
Thanks for the patchset.
I tested it on mt8173 (elm) with chromeos userspace.
Before that patchset, the test:
tast -verbose run -build=false 10.42.0.175 video.DecodeAccel.h264
sometimes passed and sometimes failed with 'context deadline exceeded'.
With this patchset it seems that the test always passes so I added tested-by:
Tested-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Thanks,
Dafna
On 14.07.21 04:56, Yong Wu wrote:
> MediaTek IOMMU block diagram always like below:
>
> M4U
> |
> smi-common
> |
> -------------
> | | ...
> | |
> larb1 larb2
> | |
> vdec venc
>
> All the consumer connect with smi-larb, then connect with smi-common.
>
> When the consumer works, it should enable the smi-larb's power which also
> need enable the smi-common's power firstly.
>
> Thus, Firstly, use the device link connect the consumer and the
> smi-larbs. then add device link between the smi-larb and smi-common.
>
> After adding the device_link, then "mediatek,larb" property can be removed.
> the iommu consumer don't need call the mtk_smi_larb_get/put to enable
> the power and clock of smi-larb and smi-common.
>
> About the MM dt-binding/dtsi patches, I guess they should go together, thus
> I don't split them for each a MM module and each a SoC.
>
> Base on v5.14-rc1, and a jpeg[1] and mdp[2] patchset.
>
> [1] https://lore.kernel.org/linux-mediatek/20210702102304.3346429-1-hsinyi@chromium.org/
> [2] https://lore.kernel.org/linux-mediatek/20210709022324.1607884-1-eizan@chromium.org/
>
> Change notes:
> v6: 1) rebase on v5.14-rc1.
> 2) Fix the issue commented in v5 from Dafna and Hsin-Yi.
> 3) Remove the patches about using pm_runtime_resume_and_get since they have
> already been merged by other patches.
>
> v5: https://lore.kernel.org/linux-mediatek/20210410091128.31823-1-yong.wu@mediatek.com/
> 1) Base v5.12-rc2.
> 2) Remove changing the mtk-iommu to module_platform_driver patch, It have already been a
> independent patch.
>
> v4: https://lore.kernel.org/linux-mediatek/1590826218-23653-1-git-send-email-yong.wu@mediatek.com/
> base on v5.7-rc1.
> 1) Move drm PM patch before smi patchs.
> 2) Change builtin_platform_driver to module_platform_driver since we may need
> build as module.
> 3) Rebase many patchset as above.
>
> v3: https://lore.kernel.org/linux-iommu/1567503456-24725-1-git-send-email-yong.wu@mediatek.com/
> 1) rebase on v5.3-rc1 and the latest mt8183 patchset.
> 2) Use device_is_bound to check whether the driver is ready from Matthias.
> 3) Add DL_FLAG_STATELESS flag when calling device_link_add and explain the
> reason in the commit message[3/14].
> 4) Add a display patch[12/14] into this series. otherwise it may affect
> display HW fastlogo even though it don't happen in mt8183.
>
> v2: https://lore.kernel.org/linux-iommu/1560171313-28299-1-git-send-email-yong.wu@mediatek.com/
> 1) rebase on v5.2-rc1.
> 2) Move adding device_link between the consumer and smi-larb into
> iommu_add_device from Robin.
> 3) add DL_FLAG_AUTOREMOVE_CONSUMER even though the smi is built-in from Evan.
> 4) Remove the shutdown callback in iommu.
>
> v1: https://lore.kernel.org/linux-iommu/1546318276-18993-1-git-send-email-yong.wu@mediatek.com/
>
> Yong Wu (10):
> dt-binding: mediatek: Get rid of mediatek,larb for multimedia HW
> iommu/mediatek: Add probe_defer for smi-larb
> iommu/mediatek: Add device_link between the consumer and the larb
> devices
> media: mtk-jpeg: Get rid of mtk_smi_larb_get/put
> media: mtk-mdp: Get rid of mtk_smi_larb_get/put
> drm/mediatek: Get rid of mtk_smi_larb_get/put
> media: mtk-vcodec: Get rid of mtk_smi_larb_get/put
> memory: mtk-smi: Get rid of mtk_smi_larb_get/put
> arm: dts: mediatek: Get rid of mediatek,larb for MM nodes
> arm64: dts: mediatek: Get rid of mediatek,larb for MM nodes
>
> Yongqiang Niu (1):
> drm/mediatek: Add pm runtime support for ovl and rdma
>
> .../display/mediatek/mediatek,disp.txt | 9 ----
> .../bindings/media/mediatek-jpeg-decoder.yaml | 9 ----
> .../bindings/media/mediatek-jpeg-encoder.yaml | 9 ----
> .../bindings/media/mediatek-mdp.txt | 8 ----
> .../bindings/media/mediatek-vcodec.txt | 4 --
> arch/arm/boot/dts/mt2701.dtsi | 2 -
> arch/arm/boot/dts/mt7623n.dtsi | 5 --
> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 16 -------
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 6 ---
> drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 9 +++-
> drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 9 +++-
> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 19 ++++----
> drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 36 +--------------
> drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 -
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +-
> drivers/iommu/mtk_iommu.c | 24 +++++++++-
> drivers/iommu/mtk_iommu_v1.c | 22 ++++++++-
> .../media/platform/mtk-jpeg/mtk_jpeg_core.c | 45 +-----------------
> .../media/platform/mtk-jpeg/mtk_jpeg_core.h | 2 -
> drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 46 +------------------
> drivers/media/platform/mtk-mdp/mtk_mdp_comp.h | 2 -
> drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 1 -
> .../platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 37 ++-------------
> .../platform/mtk-vcodec/mtk_vcodec_drv.h | 3 --
> .../platform/mtk-vcodec/mtk_vcodec_enc.c | 1 -
> .../platform/mtk-vcodec/mtk_vcodec_enc_pm.c | 44 ++----------------
> drivers/memory/mtk-smi.c | 14 ------
> include/soc/mediatek/smi.h | 20 --------
> 28 files changed, 85 insertions(+), 323 deletions(-)
>
next prev parent reply other threads:[~2021-07-14 8:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 2:56 [PATCH v6 00/11] Clean up "mediatek,larb" Yong Wu
2021-07-14 2:56 ` [PATCH v6 01/11] dt-binding: mediatek: Get rid of mediatek,larb for multimedia HW Yong Wu
2021-07-14 8:13 ` [PATCH v6 01/11] dt-binding: mediatek: Get rid of mediatek, larb " Dafna Hirschfeld
2021-07-14 8:49 ` Dafna Hirschfeld
2021-07-14 2:56 ` [PATCH v6 02/11] iommu/mediatek: Add probe_defer for smi-larb Yong Wu
2021-07-14 2:56 ` [PATCH v6 03/11] iommu/mediatek: Add device_link between the consumer and the larb devices Yong Wu
2021-07-14 8:26 ` Dafna Hirschfeld
2021-07-14 11:16 ` Yong Wu
2021-07-14 2:56 ` [PATCH v6 04/11] media: mtk-jpeg: Get rid of mtk_smi_larb_get/put Yong Wu
2021-07-14 8:28 ` Dafna Hirschfeld
2021-07-14 2:56 ` [PATCH v6 05/11] media: mtk-mdp: " Yong Wu
2021-07-14 8:29 ` Dafna Hirschfeld
2021-07-14 2:56 ` [PATCH v6 06/11] drm/mediatek: Add pm runtime support for ovl and rdma Yong Wu
2021-07-14 8:44 ` Dafna Hirschfeld
2021-07-14 11:17 ` Yong Wu
2021-07-14 2:56 ` [PATCH v6 07/11] drm/mediatek: Get rid of mtk_smi_larb_get/put Yong Wu
2021-07-14 8:30 ` Dafna Hirschfeld
2021-07-14 2:56 ` [PATCH v6 08/11] media: mtk-vcodec: " Yong Wu
2021-07-14 8:31 ` Dafna Hirschfeld
2021-07-14 2:56 ` [PATCH v6 09/11] memory: mtk-smi: " Yong Wu
2021-07-14 8:32 ` Dafna Hirschfeld
2021-07-14 2:56 ` [PATCH v6 10/11] arm: dts: mediatek: Get rid of mediatek,larb for MM nodes Yong Wu
2021-07-14 2:56 ` [PATCH v6 11/11] arm64: " Yong Wu
2021-07-14 8:56 ` Dafna Hirschfeld [this message]
2021-07-14 11:18 ` [PATCH v6 00/11] Clean up "mediatek,larb" Yong Wu
2021-07-14 8:59 ` Aw: " Frank Wunderlich
2021-07-14 11:18 ` Yong Wu
2021-07-14 11:23 ` Aw: " Frank Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=672ef386-aa95-da45-0f17-acb398a1f6e0@collabora.com \
--to=dafna.hirschfeld@collabora.com \
--cc=acourbot@chromium.org \
--cc=airlied@linux.ie \
--cc=anan.sun@mediatek.com \
--cc=anthony.huang@mediatek.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=eizan@chromium.org \
--cc=evgreen@chromium.org \
--cc=hsinyi@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=ming-fan.chen@mediatek.com \
--cc=mka@chromium.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=tiffany.lin@mediatek.com \
--cc=will.deacon@arm.com \
--cc=xia.jiang@mediatek.com \
--cc=yi.kuo@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).