From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: David Laight <David.Laight@aculab.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 3/3] perf/x86/intel/uncore: Validate MMIO address before accessing
Date: Thu, 28 May 2020 10:08:29 -0400 [thread overview]
Message-ID: <6746309b-c761-e338-c7d6-85ab6edb9052@linux.intel.com> (raw)
In-Reply-To: <20200528140226.GI611145@tassilo.jf.intel.com>
On 5/28/2020 10:02 AM, Andi Kleen wrote:
>>>> +
>>>> + pr_warn_once("perf uncore: Access invalid address of %s.\n",
>>>> + box->pmu->type->name);
>>>
>>> Pretty hard to debug without the invalid offset.
>>>
>>
>> I will dump the box->io_addr and offset for debugging.
>
> Please don't overengineer.
>
OK. Will only dump the invalid offset.
Thanks,
Kan
prev parent reply other threads:[~2020-05-28 14:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 13:15 [PATCH V2 1/3] perf/x86/intel/uncore: Fix oops when counting IMC uncore events on some TGL kan.liang
2020-05-28 13:15 ` [PATCH V2 2/3] perf/x86/intel/uncore: Record the size of mapped area kan.liang
2020-05-28 13:29 ` Andi Kleen
2020-05-28 13:44 ` Liang, Kan
2020-05-28 13:15 ` [PATCH V2 3/3] perf/x86/intel/uncore: Validate MMIO address before accessing kan.liang
2020-05-28 13:30 ` Andi Kleen
2020-05-28 13:46 ` Liang, Kan
2020-05-28 13:33 ` David Laight
2020-05-28 13:49 ` Liang, Kan
2020-05-28 14:02 ` Andi Kleen
2020-05-28 14:08 ` Liang, Kan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6746309b-c761-e338-c7d6-85ab6edb9052@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=David.Laight@aculab.com \
--cc=ak@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).