From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754907Ab3BDNJP (ORCPT ); Mon, 4 Feb 2013 08:09:15 -0500 Received: from mx2.promwad.com ([195.222.87.218]:48405 "EHLO mx2.promwad.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754151Ab3BDNJO (ORCPT ); Mon, 4 Feb 2013 08:09:14 -0500 Date: Mon, 4 Feb 2013 16:08:58 +0300 From: Michail Kurachkin X-Mailer: The Bat! (v3.64.01 Christmas Edition) Professional Reply-To: promwad_imap Organization: promwad X-Priority: 3 (Normal) Message-ID: <6757302.20130204160858@promwad.com> To: Oliver Neukum CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Kuten Ivan , "benavi@marvell.com" , Palstsiuk Viktar Subject: Re[2]: TDM bus support in Linux Kernel [PATCH] In-Reply-To: <1445550.3M3gD8CvZe@linux-5eaq.site> References: <1445550.3M3gD8CvZe@linux-5eaq.site> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Oliver, Thank you for the code review. I am working on the sources and soon will send you the update. By the way, I did not find suitable implementation of software circular buffer management. src/include/linux/circ_buf.h seems to be very limited solution. What do you think about adding the following functions/macros to the global namespace? int cb_init(struct circ_buf *cb, int item_size, int count); void cb_free(struct circ_buf *cb); int cb_push(struct circ_buf *cb, void *item); int cb_pop(struct circ_buf *cb, void *item); int cb_is_full(struct circ_buf *cb); int cb_is_empty(struct circ_buf *cb); > On Wednesday 30 January 2013 12:37:25 Kurachkin Michail wrote: >> Hi Greg, >> >> I followed your recommendations and created a diff using Linux 3.8-rc5 sources. Please review it and give your comments. -- Kurochkin Michail Software engineer Promwad Innovation Company 22, Olshevskogo St., 220073, Minsk, BELARUS phone: +375 17 312-1246 ext. 801 mobile: +375 29 609-1024 mail: Michail.Kurachkin@promwad.com www: www.promwad.com