From: Javier Martinez Canillas <javierm@redhat.com>
To: Neil Armstrong <narmstrong@baylibre.com>, linux-kernel@vger.kernel.org
Cc: Chen-Yu Tsai <wens@kernel.org>, David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, Mark Brown <broonie@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver
Date: Fri, 8 Apr 2022 10:23:12 +0200 [thread overview]
Message-ID: <67634336-4711-d643-03d3-d2514af55917@redhat.com> (raw)
In-Reply-To: <58e38622-a041-3e5c-3dca-fa95cd5f59be@baylibre.com>
Hello Neil,
Thanks for your feedback.
On 4/8/22 09:49, Neil Armstrong wrote:
[snip]
>>
>> +static struct ssd130x_deviceinfo ssd130x_variants[] = {
>> + {
>> + .default_vcomh = 0x40,
>> + .default_dclk_div = 1,
>> + .default_dclk_frq = 5,
>> + .page_mode_only = 1,
>> + },
>
> Why not [SH1106_ID] = {
>
> and later:
>
> if (variant < NR_SSD130X_VARIANTS)
> ssd130x->device_info = ssd130x_variants[variant];
>
> instead of less efficient ssd13x_variant_to_info ?
>
Indeed. I'll change that in v2.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-04-08 8:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 20:01 [PATCH 0/5] drm/solomon: Add SSD130x OLED displays SPI support Javier Martinez Canillas
2022-04-07 20:02 ` [PATCH 1/5] dt-bindings: display: ssd1307fb: Deprecate fbdev compatible strings Javier Martinez Canillas
2022-04-08 18:22 ` Rob Herring
2022-04-08 19:19 ` Javier Martinez Canillas
2022-04-08 19:25 ` Javier Martinez Canillas
2022-04-11 13:47 ` Geert Uytterhoeven
2022-04-11 14:48 ` Javier Martinez Canillas
2022-04-07 20:02 ` [PATCH 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers Javier Martinez Canillas
2022-04-07 20:02 ` [PATCH 3/5] drm/solomon: Add ssd130x-i2c compatible strings without an -fb suffix Javier Martinez Canillas
2022-04-07 20:02 ` [PATCH 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver Javier Martinez Canillas
2022-04-08 7:49 ` Neil Armstrong
2022-04-08 8:23 ` Javier Martinez Canillas [this message]
2022-04-07 20:02 ` [PATCH 5/5] drm/solomon: Add SSD130x OLED displays SPI support Javier Martinez Canillas
2022-04-08 11:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67634336-4711-d643-03d3-d2514af55917@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@linux.ie \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).