From: "Wang, Haiyue" <haiyue.wang@linux.intel.com>
To: minyard@acm.org, Nicholas Mc Guire <hofrat@osadl.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi: kcs_bmc: handle devm_kasprintf() failure case
Date: Wed, 28 Nov 2018 08:54:06 +0800 [thread overview]
Message-ID: <67962bdd-f7db-5a7d-e5d8-baaefd748ab5@linux.intel.com> (raw)
In-Reply-To: <9320680f-679e-fc89-4349-17dbbd30bbfc@acm.org>
[Resend for wrong reply HTML format mail]
Great check for making kcs_bmc module be more stable and handle things gracefully.
My tag if needed.
Reviewed-by: Haiyue Wang<haiyue.wang@linux.intel.com>
在 2018-11-27 21:36, Corey Minyard 写道:
> On 11/21/18 9:08 AM, Nicholas Mc Guire wrote:
>> devm_kasprintf() may return NULL if internal allocation failed so this
>> assignment is not safe. Moved the error exit path and added the !NULL
>> which then allows the devres manager to take care of cleanup.
>
>
> Added the original author. This looks correct to me, I've included
> it, but I would
> like Haiyue to comment, if possible.
>
> Thanks,
>
> -corey
>
>
>> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
>> Fixes: cd2315d471f4 ("ipmi: kcs_bmc: don't change device name")
next prev parent reply other threads:[~2018-11-28 0:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 15:08 [PATCH] ipmi: kcs_bmc: handle devm_kasprintf() failure case Nicholas Mc Guire
2018-11-27 13:36 ` Corey Minyard
2018-11-28 0:54 ` Wang, Haiyue [this message]
2018-11-28 0:55 ` [Openipmi-developer] " Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67962bdd-f7db-5a7d-e5d8-baaefd748ab5@linux.intel.com \
--to=haiyue.wang@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hofrat@osadl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).