From: Heiko Stuebner <heiko@sntech.de>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Levin Du <djw@t-chip.com.cn>, Akash Gajjar <akash@openedev.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Da Xue <da@lessconfused.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-amarula@amarulasolutions.com
Subject: Re: [PATCH 1/6] arm64: dts: rockchip: Fix rk3399-roc-pc pwm2 pin
Date: Sun, 29 Sep 2019 23:21:34 +0200 [thread overview]
Message-ID: <6797961.eJj5WIFbM9@phil> (raw)
In-Reply-To: <20190919052822.10403-2-jagan@amarulasolutions.com>
Hi Jagan,
Am Donnerstag, 19. September 2019, 07:28:17 CEST schrieb Jagan Teki:
> ROC-PC is not able to boot linux console if PWM2_d is
> unattached to any pinctrl logic.
>
> To be precise the linux boot hang with last logs as,
> ...
> .....
> [ 0.003367] Console: colour dummy device 80x25
> [ 0.003788] printk: console [tty0] enabled
> [ 0.004178] printk: bootconsole [uart8250] disabled
>
> In ROC-PC the PWM2_d pin is connected to LOG_DVS_PWM of
> VDD_LOG. So, for normal working operations this needs to
> active and pull-down.
>
> This patch fix, by attaching pinctrl active and pull-down
> the pwm2.
This looks highly dubious on first glance. The pwm subsystem nor
the Rockchip pwm driver do not do any pinctrl handling.
So I don't really see where that "active" pinctrl state is supposed
to come from.
Comparing with the pwm driver in the vendor tree I see that there
is such a state defined there. But that code there also looks strange
as that driver never again leaves this active state after entering it.
Also for example all the Gru devices run with quite a number of pwm-
regulators without needing additional fiddling with the pwm itself, so
I don't really see why that should be different here.
Heiko
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts
> index 19f7732d728c..c53f3d571620 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts
> @@ -548,6 +548,8 @@
> };
>
> &pwm2 {
> + pinctrl-names = "active";
> + pinctrl-0 = <&pwm2_pin_pull_down>;
> status = "okay";
> };
>
>
next prev parent reply other threads:[~2019-09-29 21:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 5:28 [PATCH 0/6] arm64: dts: rockchip: ROC-PC fixes Jagan Teki
2019-09-19 5:28 ` [PATCH 1/6] arm64: dts: rockchip: Fix rk3399-roc-pc pwm2 pin Jagan Teki
2019-09-29 21:21 ` Heiko Stuebner [this message]
2019-10-01 10:26 ` Jagan Teki
2019-10-01 10:34 ` Michael Nazzareno Trimarchi
2019-10-08 3:11 ` djw
2019-10-16 17:09 ` Jagan Teki
2019-10-17 13:26 ` Markus Reichl
2019-10-17 13:49 ` Jagan Teki
2019-10-17 23:33 ` Heiko Stuebner
2019-10-22 6:19 ` djw
2019-09-19 5:28 ` [PATCH 2/6] dt-bindings: arm: rockchip: Use libretech for roc-pc binding Jagan Teki
2019-09-19 5:28 ` [PATCH 3/6] arm64: dts: rockchip: Use libretech model, compatible for ROC-PC Jagan Teki
2019-09-19 5:28 ` [PATCH 4/6] arm64: dts: rockchip: Rename roc-pc with libretech notation Jagan Teki
2019-09-29 21:32 ` Heiko Stuebner
2019-10-01 10:33 ` Jagan Teki
2019-10-01 11:01 ` Chen-Yu Tsai
2019-09-19 5:28 ` [PATCH 5/6] arm64: dts: rockchip: Rename vcc12v_sys into dc_12v for roc-rk3399-pc Jagan Teki
2019-10-03 22:49 ` Heiko Stuebner
2019-09-19 5:28 ` [PATCH 6/6] arm64: dts: rockchip: Fix roc-rk3399-pc regulator input rails Jagan Teki
2019-10-03 22:50 ` Heiko Stuebner
2019-10-16 17:11 ` [PATCH 0/6] arm64: dts: rockchip: ROC-PC fixes Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6797961.eJj5WIFbM9@phil \
--to=heiko@sntech.de \
--cc=akash@openedev.com \
--cc=da@lessconfused.com \
--cc=devicetree@vger.kernel.org \
--cc=djw@t-chip.com.cn \
--cc=jagan@amarulasolutions.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).