linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] tty: ipwireless: Fix potential NULL pointer dereference
@ 2019-01-30 10:26 YueHaibing
  2019-01-30 10:28 ` YueHaibing
  0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-01-30 10:26 UTC (permalink / raw)
  To: dsterba, gregkh, jslaby; +Cc: linux-kernel, jikos, YueHaibing

There is a potential NULL pointer dereference in case
alloc_ctrl_packet() fails and returns NULL.

Fixes: 099dc4fb6265 ("ipwireless: driver for PC Card 3G/UMTS modem")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/tty/ipwireless/hardware.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/tty/ipwireless/hardware.c b/drivers/tty/ipwireless/hardware.c
index b0baa4c..1e21ae3 100644
--- a/drivers/tty/ipwireless/hardware.c
+++ b/drivers/tty/ipwireless/hardware.c
@@ -1516,6 +1516,8 @@ static void ipw_send_setup_packet(struct ipw_hardware *hw)
 			sizeof(struct ipw_setup_get_version_query_packet),
 			ADDR_SETUP_PROT, TL_PROTOCOLID_SETUP,
 			TL_SETUP_SIGNO_GET_VERSION_QRY);
+	if (!ver_packet)
+		return -ENOMEM;
 	ver_packet->header.length = sizeof(struct tl_setup_get_version_qry);
 
 	/*
-- 
2.7.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] tty: ipwireless: Fix potential NULL pointer dereference
  2019-01-30 10:26 [PATCH -next] tty: ipwireless: Fix potential NULL pointer dereference YueHaibing
@ 2019-01-30 10:28 ` YueHaibing
  0 siblings, 0 replies; 2+ messages in thread
From: YueHaibing @ 2019-01-30 10:28 UTC (permalink / raw)
  To: dsterba, gregkh, jslaby; +Cc: linux-kernel, jikos

Pls ignore this, sorry.

On 2019/1/30 18:26, YueHaibing wrote:
> There is a potential NULL pointer dereference in case
> alloc_ctrl_packet() fails and returns NULL.
> 
> Fixes: 099dc4fb6265 ("ipwireless: driver for PC Card 3G/UMTS modem")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/tty/ipwireless/hardware.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/tty/ipwireless/hardware.c b/drivers/tty/ipwireless/hardware.c
> index b0baa4c..1e21ae3 100644
> --- a/drivers/tty/ipwireless/hardware.c
> +++ b/drivers/tty/ipwireless/hardware.c
> @@ -1516,6 +1516,8 @@ static void ipw_send_setup_packet(struct ipw_hardware *hw)
>  			sizeof(struct ipw_setup_get_version_query_packet),
>  			ADDR_SETUP_PROT, TL_PROTOCOLID_SETUP,
>  			TL_SETUP_SIGNO_GET_VERSION_QRY);
> +	if (!ver_packet)
> +		return -ENOMEM;
>  	ver_packet->header.length = sizeof(struct tl_setup_get_version_qry);
>  
>  	/*
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-01-30 10:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-30 10:26 [PATCH -next] tty: ipwireless: Fix potential NULL pointer dereference YueHaibing
2019-01-30 10:28 ` YueHaibing

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).