From: Sibi Sankar <sibis@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Ohad Ben-Cohen <ohad@wizery.com>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rishabh Bhatnagar <rishabhb@codeaurora.org>,
linux-kernel-owner@vger.kernel.org
Subject: Re: [PATCH 2/2] remoteproc: qcom: pas: Add SM8250 PAS remoteprocs
Date: Tue, 28 Apr 2020 16:01:19 +0530 [thread overview]
Message-ID: <67b0b2a8b9581ddafb48e7f808e47857@codeaurora.org> (raw)
In-Reply-To: <20200428000110.2958704-2-bjorn.andersson@linaro.org>
Hey Bjorn,
On 2020-04-28 05:31, Bjorn Andersson wrote:
> Add audio, compute and sensor DSP compatibles to the Qualcomm PAS
> binding and driver.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/remoteproc/qcom_q6v5_pas.c | 62 ++++++++++++++++++++++++++++++
> 1 file changed, 62 insertions(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c
> b/drivers/remoteproc/qcom_q6v5_pas.c
> index 8ecc157f1ed1..5f2266c74448 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -508,6 +508,26 @@ static const struct adsp_data sm8150_adsp_resource
> = {
> .ssctl_id = 0x14,
> };
>
> +static const struct adsp_data sm8250_adsp_resource = {
> + .crash_reason_smem = 423,
> + .firmware_name = "adsp.mdt",
> + .pas_id = 1,
> + .has_aggre2_clk = false,
> + .auto_boot = true,
> + .active_pd_names = (char*[]){
> + "load_state",
> + NULL
> + },
> + .proxy_pd_names = (char*[]){
> + "cx",
> + "mx",
you may want to name it as lcx, lmx.
The remaining looks good!
Reviewed-by: Sibi Sankar <sibis@codeaurora.org>
> + NULL
> + },
> + .ssr_name = "lpass",
> + .sysmon_name = "adsp",
> + .ssctl_id = 0x14,
> +};
> +
> static const struct adsp_data msm8998_adsp_resource = {
> .crash_reason_smem = 423,
> .firmware_name = "adsp.mdt",
> @@ -553,6 +573,25 @@ static const struct adsp_data sm8150_cdsp_resource
> = {
> .ssctl_id = 0x17,
> };
>
> +static const struct adsp_data sm8250_cdsp_resource = {
> + .crash_reason_smem = 601,
> + .firmware_name = "cdsp.mdt",
> + .pas_id = 18,
> + .has_aggre2_clk = false,
> + .auto_boot = true,
> + .active_pd_names = (char*[]){
> + "load_state",
> + NULL
> + },
> + .proxy_pd_names = (char*[]){
> + "cx",
> + NULL
> + },
> + .ssr_name = "cdsp",
> + .sysmon_name = "cdsp",
> + .ssctl_id = 0x17,
> +};
> +
> static const struct adsp_data mpss_resource_init = {
> .crash_reason_smem = 421,
> .firmware_name = "modem.mdt",
> @@ -604,6 +643,26 @@ static const struct adsp_data sm8150_slpi_resource
> = {
> .ssctl_id = 0x16,
> };
>
> +static const struct adsp_data sm8250_slpi_resource = {
> + .crash_reason_smem = 424,
> + .firmware_name = "slpi.mdt",
> + .pas_id = 12,
> + .has_aggre2_clk = false,
> + .auto_boot = true,
> + .active_pd_names = (char*[]){
> + "load_state",
> + NULL
> + },
> + .proxy_pd_names = (char*[]){
> + "lcx",
> + "lmx",
> + NULL
> + },
> + .ssr_name = "dsps",
> + .sysmon_name = "slpi",
> + .ssctl_id = 0x16,
> +};
> +
> static const struct adsp_data msm8998_slpi_resource = {
> .crash_reason_smem = 424,
> .firmware_name = "slpi.mdt",
> @@ -644,6 +703,9 @@ static const struct of_device_id adsp_of_match[] =
> {
> { .compatible = "qcom,sm8150-cdsp-pas", .data =
> &sm8150_cdsp_resource},
> { .compatible = "qcom,sm8150-mpss-pas", .data = &mpss_resource_init},
> { .compatible = "qcom,sm8150-slpi-pas", .data =
> &sm8150_slpi_resource},
> + { .compatible = "qcom,sm8250-adsp-pas", .data =
> &sm8250_adsp_resource},
> + { .compatible = "qcom,sm8250-cdsp-pas", .data =
> &sm8250_cdsp_resource},
> + { .compatible = "qcom,sm8250-slpi-pas", .data =
> &sm8250_slpi_resource},
> { },
> };
> MODULE_DEVICE_TABLE(of, adsp_of_match);
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-04-28 10:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 0:01 [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8250 remoteprocs Bjorn Andersson
2020-04-28 0:01 ` [PATCH 2/2] remoteproc: qcom: pas: Add SM8250 PAS remoteprocs Bjorn Andersson
2020-04-28 10:31 ` Sibi Sankar [this message]
2020-04-28 10:25 ` [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8250 remoteprocs Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67b0b2a8b9581ddafb48e7f808e47857@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=rishabhb@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).