From: Chanwoo Choi <cwchoi00@gmail.com>
To: bumwoo lee <bw365.lee@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1] extcon: modify extcon device to be created after driver data is set
Date: Thu, 28 Apr 2022 08:16:03 +0900 [thread overview]
Message-ID: <67b840a9-c656-c871-afc1-84d2ec2c0fc3@gmail.com> (raw)
In-Reply-To: <20220427030005.706-1-bw365.lee@samsung.com>
Hi bumwoo,
On 22. 4. 27. 12:00, bumwoo lee wrote:
> Currently, someone can invoke the sysfs such as state_show()
> intermittently before dev_set_drvdata() is done.
> And it can be a cause of kernel Oops because of edev is Null at that time.
> So modified the driver registration to after setting drviver data.
>
> - Oops's backtrace.
>
> Backtrace:
> [<c067865c>] (state_show) from [<c05222e8>] (dev_attr_show)
> [<c05222c0>] (dev_attr_show) from [<c02c66e0>] (sysfs_kf_seq_show)
> [<c02c6648>] (sysfs_kf_seq_show) from [<c02c496c>] (kernfs_seq_show)
> [<c02c4938>] (kernfs_seq_show) from [<c025e2a0>] (seq_read)
> [<c025e11c>] (seq_read) from [<c02c50a0>] (kernfs_fop_read)
> [<c02c5064>] (kernfs_fop_read) from [<c0231cac>] (__vfs_read)
> [<c0231c5c>] (__vfs_read) from [<c0231ee0>] (vfs_read)
> [<c0231e34>] (vfs_read) from [<c0232464>] (ksys_read)
> [<c02323f0>] (ksys_read) from [<c02324fc>] (sys_read)
> [<c02324e4>] (sys_read) from [<c00091d0>] (__sys_trace_return)
>
> Signed-off-by: bumwoo lee <bw365.lee@samsung.com>
> ---
> drivers/extcon/extcon.c | 29 +++++++++++++++++------------
> 1 file changed, 17 insertions(+), 12 deletions(-)
(snip)
Applied it on extcon-fixes. Thanks for your work.
I change the first letter to capital letter as following:
- extcon: Modify extcon device to be created after driver data is set
And better to use the correct version on patch title on next
and then add the changes according to version as following:
If you describe changes under '---', it is no problem
when git apply with git am command.
For example.
[PATCH v2] extcon: Modify extcon device to be created after driver data
...
Signed-off-by: bumwoo lee <bw365.lee@samsung.com>
---
Changes from v1:
- explain what are changes
--
Best Regards,
Samsung Electronics
Chanwoo Choi
next prev parent reply other threads:[~2022-04-27 23:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220427030050epcas1p377eb744ed82b0e4a80747da6229fedca@epcas1p3.samsung.com>
2022-04-27 3:00 ` [PATCH V1] extcon: modify extcon device to be created after driver data is set bumwoo lee
2022-04-27 23:16 ` Chanwoo Choi [this message]
2022-04-28 0:36 ` Bumwoo Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67b840a9-c656-c871-afc1-84d2ec2c0fc3@gmail.com \
--to=cwchoi00@gmail.com \
--cc=bw365.lee@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).