From: Mario Limonciello <mario.limonciello@amd.com>
To: firew4lker <firew4lker@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Shreeya Patel <shreeya.patel@collabora.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Cc: Basavaraj.Natikar@amd.com, Richard.Gong@amd.com, stable@vger.kernel.org
Subject: Re: [PATCH] gpio: Request interrupts after IRQ is initialized
Date: Sun, 17 Apr 2022 23:34:43 -0500 [thread overview]
Message-ID: <67df4178-5943-69d8-0d61-f533671a1248@amd.com> (raw)
In-Reply-To: <20966c6b-9045-9f8b-ba35-bf44091ce380@gmail.com>
On 4/17/22 07:24, firew4lker wrote:
> On 4/14/22 05:57, Mario Limonciello wrote:
>> commit 5467801f1fcb ("gpio: Restrict usage of GPIO chip irq members
>> before
>> initialization") attempted to fix a race condition that lead to a NULL
>> pointer, but in the process caused a regression for _AEI/_EVT declared
>> GPIOs. This manifests in messages showing deferred probing while trying
>> to allocate IRQs like so:
>>
>> [ 0.688318] amd_gpio AMDI0030:00: Failed to translate GPIO pin
>> 0x0000 to IRQ, err -517
>> [ 0.688337] amd_gpio AMDI0030:00: Failed to translate GPIO pin
>> 0x002C to IRQ, err -517
>> [ 0.688348] amd_gpio AMDI0030:00: Failed to translate GPIO pin
>> 0x003D to IRQ, err -517
>> [ 0.688359] amd_gpio AMDI0030:00: Failed to translate GPIO pin
>> 0x003E to IRQ, err -517
>> [ 0.688369] amd_gpio AMDI0030:00: Failed to translate GPIO pin
>> 0x003A to IRQ, err -517
>> [ 0.688379] amd_gpio AMDI0030:00: Failed to translate GPIO pin
>> 0x003B to IRQ, err -517
>> [ 0.688389] amd_gpio AMDI0030:00: Failed to translate GPIO pin
>> 0x0002 to IRQ, err -517
>> [ 0.688399] amd_gpio AMDI0030:00: Failed to translate GPIO pin
>> 0x0011 to IRQ, err -517
>> [ 0.688410] amd_gpio AMDI0030:00: Failed to translate GPIO pin
>> 0x0012 to IRQ, err -517
>> [ 0.688420] amd_gpio AMDI0030:00: Failed to translate GPIO pin
>> 0x0007 to IRQ, err -517
>>
>> The code for walking _AEI doesn't handle deferred probing and so this
>> leads
>> to non-functional GPIO interrupts.
>>
>> Fix this issue by moving the call to
>> `acpi_gpiochip_request_interrupts` to
>> occur after gc->irc.initialized is set.
>>
>> Cc: Shreeya Patel <shreeya.patel@collabora.com>
>> Cc: stable@vger.kernel.org
>> Fixes: 5467801f1fcb ("gpio: Restrict usage of GPIO chip irq members
>> before initialization")
>> Reported-by: Mario Limonciello <mario.limonciello@amd.com>
>> Link:
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flinux-gpio%2FBL1PR12MB51577A77F000A008AA694675E2EF9%40BL1PR12MB5157.namprd12.prod.outlook.com%2FT%2F%23u&data=04%7C01%7Cmario.limonciello%40amd.com%7C96ec39c78488493fd5ca08da206d3c7b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637857951204650754%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=xZbNC%2F50JqlNwcTYAtGLn6z0%2FEPbfCKKOc%2BlZlMh0EQ%3D&reserved=0
>>
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>> drivers/gpio/gpiolib.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
>> index 085348e08986..b7694171655c 100644
>> --- a/drivers/gpio/gpiolib.c
>> +++ b/drivers/gpio/gpiolib.c
>> @@ -1601,8 +1601,6 @@ static int gpiochip_add_irqchip(struct gpio_chip
>> *gc,
>> gpiochip_set_irq_hooks(gc);
>> - acpi_gpiochip_request_interrupts(gc);
>> -
>> /*
>> * Using barrier() here to prevent compiler from reordering
>> * gc->irq.initialized before initialization of above
>> @@ -1612,6 +1610,8 @@ static int gpiochip_add_irqchip(struct gpio_chip
>> *gc,
>> gc->irq.initialized = true;
>> + acpi_gpiochip_request_interrupts(gc);
>> +
>> return 0;
>> }
>
> Tested-By:firew4lker@gmail.com
>
> This patch addresses the issue. Tested on a Lenovo T14 with AMD Ryzen 5
> PRO 4650U with Radeon Graphics Graphics.
>
> Without this patch the laptop is impossible to wake from S3 and S0ix.
>
Thanks for testing it!
Linus Walleij,
As this is backported to 5.15.y, 5.16.y, 5.17.y and those all had point
releases a bunch of people are hitting it now. If you choose to adopt
this patch instead of revert the broken one, you can add to the commit
message too:
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1976
next prev parent reply other threads:[~2022-04-18 4:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 2:57 [PATCH] gpio: Request interrupts after IRQ is initialized Mario Limonciello
2022-04-14 15:25 ` Andy Shevchenko
2022-04-14 19:11 ` Shreeya Patel
2022-04-17 12:17 ` luke
2022-04-17 12:24 ` firew4lker
2022-04-18 4:34 ` Mario Limonciello [this message]
2022-04-18 11:42 ` Andy Shevchenko
2022-04-18 13:58 ` Thorsten Leemhuis
2022-04-18 14:17 ` Andy Shevchenko
2022-04-18 15:29 ` Thorsten Leemhuis
2022-04-19 13:03 ` Limonciello, Mario
2022-04-19 22:02 ` Linus Walleij
2022-04-21 16:07 ` Thorsten Leemhuis
2022-04-22 12:18 ` Thorsten Leemhuis
2022-04-22 13:15 ` Limonciello, Mario
2022-04-18 13:46 ` Thorsten Leemhuis
2022-04-19 9:40 ` Samuel Čavoj
2022-04-19 21:59 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67df4178-5943-69d8-0d61-f533671a1248@amd.com \
--to=mario.limonciello@amd.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Richard.Gong@amd.com \
--cc=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=firew4lker@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shreeya.patel@collabora.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).