From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0B30C07E99 for ; Fri, 9 Jul 2021 06:08:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ADC4C61442 for ; Fri, 9 Jul 2021 06:08:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230075AbhGIGLf (ORCPT ); Fri, 9 Jul 2021 02:11:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:27003 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbhGIGLe (ORCPT ); Fri, 9 Jul 2021 02:11:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625810930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vy3RT833Zluxm0D5IqTflstNdttnmf/u6KXeL7O1ITo=; b=CM1CyOTMXV4AC66OPgVVCtRFmekZy+n06GNjNv3x90MyQ8y+F6KaMb9EearxtR0ybXEgIp QpJGw6SoDJKlzpOTdqTS+O0HB+VBUUr2LFRLArKFweRczpZnadSU5EtpR3rbDbGvJcusWO GC6hNgDIkk60vLsiZamBvdrW+YtMCPk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-426-zL_CMw1sPXixCGMcENOB2A-1; Fri, 09 Jul 2021 02:08:49 -0400 X-MC-Unique: zL_CMw1sPXixCGMcENOB2A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 37D49362FA; Fri, 9 Jul 2021 06:08:48 +0000 (UTC) Received: from starship (unknown [10.40.192.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id A2128100EBAF; Fri, 9 Jul 2021 06:08:44 +0000 (UTC) Message-ID: <67e2e6b4fcbc2ec0bdda1e1af1cfe61d3c1fde6f.camel@redhat.com> Subject: Re: [PATCH 1/6] KVM: nSVM: Check the value written to MSR_VM_HSAVE_PA From: Maxim Levitsky To: Paolo Bonzini , Vitaly Kuznetsov , kvm@vger.kernel.org Cc: Sean Christopherson , Wanpeng Li , Jim Mattson , Cathy Avery , Emanuele Giuseppe Esposito , Tom Lendacky , Michael Roth , linux-kernel@vger.kernel.org Date: Fri, 09 Jul 2021 09:08:43 +0300 In-Reply-To: <4318c980-6eff-7b74-ae99-b3210021789d@redhat.com> References: <20210628104425.391276-1-vkuznets@redhat.com> <20210628104425.391276-2-vkuznets@redhat.com> <595c45e8fb753556b2c01b25ac7052369c8357ac.camel@redhat.com> <4318c980-6eff-7b74-ae99-b3210021789d@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2021-07-08 at 19:27 +0200, Paolo Bonzini wrote: > On 07/07/21 12:28, Maxim Levitsky wrote: > > Minor nitpick: I would have checked the host provided value as well, > > just in case since there is no reason why it won't pass the same check, > > and fail if the value is not aligned. > > The reason not to do so is that it would allow a guest running an old > kernel to defeat live migration. I understand now, and I will keep this in mind next time. Best regards, Maxim Levitsky > > Paolo > > > Other than that: > > Reviewed-by: Maxim Levitsky