From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Vincent Shih <vincent.sunplus@gmail.com>,
gregkh@linuxfoundation.org, stern@rowland.harvard.edu,
p.zabel@pengutronix.de, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, wells.lu@sunplus.com
Subject: Re: [PATCH v3 2/2] dt-bindings: usb: Add bindings doc for Sunplus EHCI driver
Date: Sun, 6 Mar 2022 13:07:50 +0100 [thread overview]
Message-ID: <67ec6f3a-1579-f77a-a54d-381472252d6b@canonical.com> (raw)
In-Reply-To: <1646547036-14885-3-git-send-email-vincent.sunplus@gmail.com>
On 06/03/2022 07:10, Vincent Shih wrote:
> Add bindings doc for Sunplus EHCI driver
>
> Signed-off-by: Vincent Shih <vincent.sunplus@gmail.com>
> ---
> Changes in v2:
> - Address the comments by Rob Herring.
>
> .../bindings/usb/sunplus,sp7021-usb-ehci.yaml | 63 ++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 64 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml b/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml
> new file mode 100644
> index 0000000..905f68c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd. 2021
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/sunplus,sp7021-usb-ehci.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sunplus SP7021 EHCI Controller Device Tree bindings
s/Device Tree bindings//
(title describes hardware)
> +
> +allOf:
> + - $ref: usb-hcd.yaml#
> +
> +maintainers:
> + - Vincent Shih <vincent.sunplus@gmail.com>
> +
> +properties:
> + compatible:
> + const: sunplus,sp7021-usb2-ehci
You do not use this compatible in the driver.
> +
> + clocks:
> + maxItems: 1
> +
> + resets:
> + minItems: 1
Suddenly it became minItems. This looks odd, it should be maxItems: 1
rather. How many reset lines do you have there?
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + phys:
> + maxItems: 1
> +
> + phy-names:
> + maxItems: 1
phy-names needs list of names.
> +
> +required:
> + - compatible
> + - clocks
> + - resets
> + - reg
> + - interrupts
> + - phys
> + - phy-names
> +
> +additionalProperties: false
This should be unevaluatedProperties:false, because you reference
usb-hcd schema.
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + sp_ehci0: usb@9c102100 {
> + compatible = "sunplus,sp7021-usb-ehci";
> + clocks = <&clkc 0x3a>;
> + resets = <&rstc 0x2a>;
> + reg = <0x9c102100 0x68>;
reg goes after compatible in DTS.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-06 12:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-06 6:10 [PATCH v3 0/2] Add driver for ehci in Sunplus SP7021 Vincent Shih
2022-03-06 6:10 ` [PATCH v3 1/2] usb: host: ehci-sunplus: " Vincent Shih
2022-03-06 6:10 ` [PATCH v3 2/2] dt-bindings: usb: Add bindings doc for Sunplus EHCI driver Vincent Shih
2022-03-06 12:07 ` Krzysztof Kozlowski [this message]
2022-03-07 3:24 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67ec6f3a-1579-f77a-a54d-381472252d6b@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=vincent.sunplus@gmail.com \
--cc=wells.lu@sunplus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).