linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>, Tejun Heo <tj@kernel.org>
Cc: rjw@rjwysocki.net, alan.cox@intel.com, linux-ide@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	Mario.Limonciello@dell.com
Subject: Re: [RFC PATCH] ata: ahci: Enable DEVSLP by default on x86 modern standby platform
Date: Thu, 05 Jul 2018 17:52:08 -0700	[thread overview]
Message-ID: <681dbd37f209a29be46e9c4ff102631cfa841ec0.camel@linux.intel.com> (raw)
In-Reply-To: <660d4e4b-361f-e6b1-ef21-3985c321183a@redhat.com>

Hi Hans,


[...]

> So digging a bit deeper I just realized that another important
> difference
> between med_power_with_dipm and min_power is that min_power by
> default
> set the ASP bits making the link go to the slumber state instead of
> to
> the partial (power-saving) state.
> 
> According to:
> https://www.intel.com/content/dam/doc/reference-guide/sata-devices-im
> plementation-recommendations.pdf
> 
> ASP defaults to off in the iRST drivers. But that is a document from
> before DEVSLP got introduced.
> 
> So we need to know if Windows and/or the iRST drivers use HIPM and
> ASP by default on these systems. If they do then using min_power
> is fine. If they don't use one or the other we are going to need
> a new policy reflecting those settings and use that.
Good point. In Windows there are various registry settings, so they can
be tuned. It is difficult to know what they mean.
Let me do some experiments to check impact of ASP on SLP_S0. Then I
will resubmit this patch.

Thanks,
Srinivas

> 
> Regards,
> 
> Hans
> 

      reply	other threads:[~2018-07-06  0:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02 19:08 [RFC PATCH] ata: ahci: Enable DEVSLP by default on x86 modern standby platform Srinivas Pandruvada
2018-07-02 20:21 ` Tejun Heo
2018-07-02 21:27   ` Hans de Goede
2018-07-02 22:08     ` Srinivas Pandruvada
2018-07-02 22:56       ` Mario.Limonciello
2018-07-03  8:57       ` Hans de Goede
2018-07-03 10:21         ` Hans de Goede
2018-07-06  0:52           ` Srinivas Pandruvada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=681dbd37f209a29be46e9c4ff102631cfa841ec0.camel@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=Mario.Limonciello@dell.com \
    --cc=alan.cox@intel.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).