From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9248C433E0 for ; Wed, 6 Jan 2021 00:52:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 920B8221E2 for ; Wed, 6 Jan 2021 00:52:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726253AbhAFAwR (ORCPT ); Tue, 5 Jan 2021 19:52:17 -0500 Received: from m43-15.mailgun.net ([69.72.43.15]:39672 "EHLO m43-15.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725868AbhAFAwQ (ORCPT ); Tue, 5 Jan 2021 19:52:16 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1609894312; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=PZc2NcG7uuh+6im8cfLwXFTleXn53JDpJ97p6N/GsAg=; b=ZNS2LQT6qk9u3RgAy6RRKcP8sOjkK0BXV1cOCpe/OZL1vZeSHmyV3GlSfs0IXzU7VCJJ0Yhi 9kPNpty3Co1Zh9qKByrytqEJaNn6SAE2eW7zElKxA0GUgq2jA8njzJP7v87IaPAZhCe++iwW 7WDF6va9weBN8io387mRKsCP99M= X-Mailgun-Sending-Ip: 69.72.43.15 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 5ff509a2d3eb3c36b4c3cc6c (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 06 Jan 2021 00:51:46 GMT Sender: cang=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E8BD4C4346A; Wed, 6 Jan 2021 00:51:45 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id 007A9C433CA; Wed, 6 Jan 2021 00:51:42 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 06 Jan 2021 08:51:42 +0800 From: Can Guo To: Greg KH Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, Andy Gross , Bjorn Andersson , Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , "open list:ARM/QUALCOMM SUPPORT" , open list Subject: Re: [PATCH 2/2] scsi: ufs-qcom: Add one sysfs node to monitor performance In-Reply-To: References: <1609816552-16442-1-git-send-email-cang@codeaurora.org> <1609816552-16442-3-git-send-email-cang@codeaurora.org> Message-ID: <684aabf8070279e380e03ec7b891330d@codeaurora.org> X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-01-05 18:27, Greg KH wrote: > Oops, forgot the big problem that I noticed: > > On Mon, Jan 04, 2021 at 07:15:51PM -0800, Can Guo wrote: >> +static ssize_t monitor_show(struct device *dev, struct >> device_attribute *attr, >> + char *buf) >> +{ >> + struct ufs_hba *hba = dev_get_drvdata(dev); >> + struct ufs_qcom_host *host = ufshcd_get_variant(hba); >> + struct ufs_qcom_perf_monitor *mon = &host->monitor; >> + unsigned long nr_sec_rd, nr_sec_wr, busy_us_rd, busy_us_wr; >> + unsigned long lat_max_rd, lat_min_rd, lat_sum_rd, lat_avg_rd, >> nr_req_rd; >> + unsigned long lat_max_wr, lat_min_wr, lat_sum_wr, lat_avg_wr, >> nr_req_wr; >> + bool is_enabled; >> + >> + /* >> + * Don't lock the host lock since user needs to cat the entry very >> + * frequently during performance test, otherwise it may impact the >> + * performance. >> + */ >> + is_enabled = mon->enabled; >> + if (!is_enabled) >> + goto print_usage; >> + >> + nr_sec_rd = mon->nr_sec_rw[READ]; >> + nr_sec_wr = mon->nr_sec_rw[WRITE]; >> + busy_us_rd = ktime_to_us(mon->total_busy[READ]); >> + busy_us_wr = ktime_to_us(mon->total_busy[WRITE]); >> + >> + nr_req_rd = mon->nr_req[READ]; >> + lat_max_rd = ktime_to_us(mon->lat_max[READ]); >> + lat_min_rd = ktime_to_us(mon->lat_min[READ]); >> + lat_sum_rd = ktime_to_us(mon->lat_sum[READ]); >> + lat_avg_rd = lat_sum_rd / nr_req_rd; >> + >> + nr_req_wr = mon->nr_req[WRITE]; >> + lat_max_wr = ktime_to_us(mon->lat_max[WRITE]); >> + lat_min_wr = ktime_to_us(mon->lat_min[WRITE]); >> + lat_sum_wr = ktime_to_us(mon->lat_sum[WRITE]); >> + lat_avg_wr = lat_sum_wr / nr_req_wr; >> + >> + return scnprintf(buf, PAGE_SIZE, "Read %lu %s %lu us, %lu %s max %lu >> | min %lu | avg %lu | sum %lu\nWrite %lu %s %lu us, %lu %s max %lu | >> min %lu | avg %lu | sum %lu\n", >> + nr_sec_rd, "sectors (in 512 bytes) in ", busy_us_rd, >> + nr_req_rd, "read reqs completed, latencies in us: ", >> + lat_max_rd, lat_min_rd, lat_avg_rd, lat_sum_rd, >> + nr_sec_wr, "sectors (in 512 bytes) in ", busy_us_wr, >> + nr_req_wr, "write reqs completed, latencies in us: ", >> + lat_max_wr, lat_min_wr, lat_avg_wr, lat_sum_wr); > > sysfs is one-value-per-file, not > throw-everything-in-one-file-and-hope-userspace-can-parse-it. > > This is not acceptable at all. Why not just use debugfs for stats like > this? > > Also, use sysfs_emit() for any new sysfs files please. > > thanks, > > greg k-h Hi Greg, Thanks for the comments, I will rework the change to make it right. Regards, Can Guo.