From: Daniel Bristot de Oliveira <bristot@redhat.com>
To: Anna-Maria Gleixner <anna-maria@linutronix.de>,
linux-kernel@vger.kernel.org
Cc: bigeasy@linutronix.de, tglx@linutronix.de, frederic@kernel.org,
paulmck@linux.vnet.ibm.com, peterz@infradead.org
Subject: Re: [PATCH] nohz: Fix local_timer_softirq_pending()
Date: Tue, 31 Jul 2018 19:07:45 +0200 [thread overview]
Message-ID: <686f5d08-e910-9be1-6914-3164e723c16e@redhat.com> (raw)
In-Reply-To: <20180731161358.29472-1-anna-maria@linutronix.de>
On 07/31/2018 06:13 PM, Anna-Maria Gleixner wrote:
> local_timer_softirq_pending() checks whether the timer softirq is
> pending with: local_softirq_pending() & TIMER_SOFTIRQ.
>
> This is wrong because TIMER_SOFTIRQ is the softirq number and not a
> bitmask. So the test checks for the wrong bit.
>
> Use BIT(TIMER_SOFTIRQ) instead.
Reviewed-by: Daniel Bristot de Oliveira <bristot@redhat.com>
Thanks!
-- Daniel
> Fixes: 5d62c183f9e9 ("nohz: Prevent a timer interrupt storm in tick_nohz_stop_sched_tick()")
> Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
> ---
> kernel/time/tick-sched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
> index da9455a6b42b..5b33e2f5c0ed 100644
> --- a/kernel/time/tick-sched.c
> +++ b/kernel/time/tick-sched.c
> @@ -642,7 +642,7 @@ static void tick_nohz_restart(struct tick_sched *ts, ktime_t now)
>
> static inline bool local_timer_softirq_pending(void)
> {
> - return local_softirq_pending() & TIMER_SOFTIRQ;
> + return local_softirq_pending() & BIT(TIMER_SOFTIRQ);
> }
>
> static ktime_t tick_nohz_next_event(struct tick_sched *ts, int cpu)
>
next prev parent reply other threads:[~2018-07-31 17:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 16:13 [PATCH] nohz: Fix local_timer_softirq_pending() Anna-Maria Gleixner
2018-07-31 16:50 ` Paul E. McKenney
2018-07-31 17:07 ` Daniel Bristot de Oliveira [this message]
2018-07-31 17:14 ` Frederic Weisbecker
2018-07-31 20:13 ` [tip:timers/urgent] " tip-bot for Anna-Maria Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=686f5d08-e910-9be1-6914-3164e723c16e@redhat.com \
--to=bristot@redhat.com \
--cc=anna-maria@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).