linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] mm: fix comments related to node reclaim
@ 2019-11-26 14:13 Hao Lee
  2019-11-28  5:27 ` Anshuman Khandual
  0 siblings, 1 reply; 2+ messages in thread
From: Hao Lee @ 2019-11-26 14:13 UTC (permalink / raw)
  To: akpm; +Cc: mgorman, anshuman.khandual, linux-mm, linux-kernel, haolee.swjtu

As zone reclaim has been replaced by node reclaim, this patch fixes related
comments.

Signed-off-by: Hao Lee <haolee.swjtu@gmail.com>
---
 include/linux/mmzone.h      | 2 +-
 include/uapi/linux/sysctl.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index 9e47289a4511..7e3208f4f5bc 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -747,7 +747,7 @@ typedef struct pglist_data {
 
 #ifdef CONFIG_NUMA
 	/*
-	 * zone reclaim becomes active if more unmapped pages exist.
+	 * node reclaim becomes active if more unmapped pages exist.
 	 */
 	unsigned long		min_unmapped_pages;
 	unsigned long		min_slab_pages;
diff --git a/include/uapi/linux/sysctl.h b/include/uapi/linux/sysctl.h
index 87aa2a6d9125..27c1ed2822e6 100644
--- a/include/uapi/linux/sysctl.h
+++ b/include/uapi/linux/sysctl.h
@@ -195,7 +195,7 @@ enum
 	VM_MIN_UNMAPPED=32,	/* Set min percent of unmapped pages */
 	VM_PANIC_ON_OOM=33,	/* panic at out-of-memory */
 	VM_VDSO_ENABLED=34,	/* map VDSO into new processes? */
-	VM_MIN_SLAB=35,		 /* Percent pages ignored by zone reclaim */
+	VM_MIN_SLAB=35,		 /* Percent pages ignored by node reclaim */
 };
 
 
-- 
2.14.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] mm: fix comments related to node reclaim
  2019-11-26 14:13 [PATCH v2] mm: fix comments related to node reclaim Hao Lee
@ 2019-11-28  5:27 ` Anshuman Khandual
  0 siblings, 0 replies; 2+ messages in thread
From: Anshuman Khandual @ 2019-11-28  5:27 UTC (permalink / raw)
  To: Hao Lee, akpm; +Cc: mgorman, linux-mm, linux-kernel



On 11/26/2019 07:43 PM, Hao Lee wrote:
> As zone reclaim has been replaced by node reclaim, this patch fixes related
> comments.
> 
> Signed-off-by: Hao Lee <haolee.swjtu@gmail.com>
> ---
>  include/linux/mmzone.h      | 2 +-
>  include/uapi/linux/sysctl.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 9e47289a4511..7e3208f4f5bc 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -747,7 +747,7 @@ typedef struct pglist_data {
>  
>  #ifdef CONFIG_NUMA
>  	/*
> -	 * zone reclaim becomes active if more unmapped pages exist.
> +	 * node reclaim becomes active if more unmapped pages exist.
>  	 */
>  	unsigned long		min_unmapped_pages;
>  	unsigned long		min_slab_pages;
> diff --git a/include/uapi/linux/sysctl.h b/include/uapi/linux/sysctl.h
> index 87aa2a6d9125..27c1ed2822e6 100644
> --- a/include/uapi/linux/sysctl.h
> +++ b/include/uapi/linux/sysctl.h
> @@ -195,7 +195,7 @@ enum
>  	VM_MIN_UNMAPPED=32,	/* Set min percent of unmapped pages */
>  	VM_PANIC_ON_OOM=33,	/* panic at out-of-memory */
>  	VM_VDSO_ENABLED=34,	/* map VDSO into new processes? */
> -	VM_MIN_SLAB=35,		 /* Percent pages ignored by zone reclaim */
> +	VM_MIN_SLAB=35,		 /* Percent pages ignored by node reclaim */
>  };

This looks good to me but wondering if this sort of change could qualify
for a stand alone patch or should be carried along with other functional
changes. Will leave it upto others to decide.

>  
>  
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-11-28  5:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-26 14:13 [PATCH v2] mm: fix comments related to node reclaim Hao Lee
2019-11-28  5:27 ` Anshuman Khandual

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).