From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Borislav Petkov <bp@alien8.de>
Cc: "mchehab@kernel.org" <mchehab@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>
Subject: Re: [PATCH] EDAC, mv64x60: Remove some code duplication
Date: Sun, 14 Jan 2018 22:48:28 +0000 [thread overview]
Message-ID: <68939e8b999644b89080ed049970c9fe@svr-chch-ex1.atlnz.lc> (raw)
In-Reply-To: 49db37d7-3d54-3ae5-9cb9-702ef14f1f43@wanadoo.fr
Hi Christophe,
On 14/01/18 06:17, Christophe JAILLET wrote:
> Le 13/01/2018 à 15:22, Borislav Petkov a écrit :
>> + Chris Packham who's been fixing some stuff in here too.
>>
>> On Sat, Jan 13, 2018 at 08:28:21AM +0100, Christophe JAILLET wrote:
>>> Reorder the error handling code in order to release the resources in
>>> reverse order than allocation.
>>>
>>> Introduce a new 'release_group' label in the error handling path and use
>>> it to void some code duplication.
>>>
>>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>>> ---
>>> drivers/edac/mv64x60_edac.c | 7 ++++---
>>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/edac/mv64x60_edac.c b/drivers/edac/mv64x60_edac.c
>>> index 3c68bb525d5d..aa5bc1d8f424 100644
>>> --- a/drivers/edac/mv64x60_edac.c
>>> +++ b/drivers/edac/mv64x60_edac.c
>>> @@ -450,8 +450,8 @@ static int mv64x60_cpu_err_probe(struct platform_device *pdev)
>>> "cpu", 1, NULL, 0, 0, NULL, 0,
>>> edac_dev_idx);
>>> if (!edac_dev) {
>>> - devres_release_group(&pdev->dev, mv64x60_cpu_err_probe);
>>> - return -ENOMEM;
>>> + res = -ENOMEM;
>>> + goto release_group;
>>> }
>>>
>>> pdata = edac_dev->pvt_info;
>>> @@ -561,8 +561,9 @@ static int mv64x60_cpu_err_probe(struct platform_device *pdev)
>>> err2:
>>> edac_device_del_device(&pdev->dev);
>>> err:
>>> - devres_release_group(&pdev->dev, mv64x60_cpu_err_probe);
>>> edac_device_free_ctl_info(edac_dev);
>>> +release_group:
>>> + devres_release_group(&pdev->dev, mv64x60_cpu_err_probe);
>>> return res;
>>> }
>>>
>>> --
>> Thanks, looks good. But looking at this driver, mv64x60_mc_err_probe()
>> and mv64x60_sram_err_probe() have the same problem too. Can you address them
>> with your patch too pls?
> Will do. mv64x60_pci_err_probe() also needs some tweaks.
>
>> Also, if you feel like fixing more stuff in this driver, it doesn't use
>> the edac_printk() infrastructure but naked printk() calls. It could be
>> converted to it.
> I will only propose to remove a useless message and improve another one,
> but won't convert the whole driver, sorry.
>
I take this you mean you have a system with a mv64x60 SoC? You might
want to make yourself known to the linuxppc-dev list. A while back the
prospects of dropping CONFIG_MV64X60 was raised[1]. I don't see anyone
actually following through on this yet but I'm not really following
linuxppc that closely.
[1] - https://marc.info/?l=linux-edac&m=149518763115206&w=2
next prev parent reply other threads:[~2018-01-14 22:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-13 7:28 [PATCH] EDAC, mv64x60: Remove some code duplication Christophe JAILLET
2018-01-13 14:22 ` Borislav Petkov
2018-01-13 17:09 ` Christophe JAILLET
2018-01-14 22:48 ` Chris Packham [this message]
2018-01-15 22:31 ` Michael Ellerman
2018-01-16 6:19 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68939e8b999644b89080ed049970c9fe@svr-chch-ex1.atlnz.lc \
--to=chris.packham@alliedtelesis.co.nz \
--cc=bp@alien8.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mchehab@kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).