From: Dag Nygren <dag@newtech.fi>
To: xen-devel@lists.xenproject.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
jgross@suse.com, "Dr . Greg Wettstein" <greg@enjellic.com>,
dunlapg@umich.edu, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, jgg@ziepe.ca,
"Dr. Greg Wettstein" <greg@wind.enjellic.com>,
peterhuewe@gmx.de, linux-integrity@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH v2] tpm: Restore functionality to xen vtpm driver.
Date: Tue, 18 Sep 2018 09:54:47 +0300 [thread overview]
Message-ID: <6898808.CzJHl40L0f@eseries.newtech.fi> (raw)
In-Reply-To: <5d63093d-620d-80d5-1138-0332a210d61f@oracle.com>
On tisdag 18 september 2018 kl. 01:25:29 EEST Boris Ostrovsky wrote:
> On 9/17/18 5:19 PM, Jarkko Sakkinen wrote:
> > Just to understand this bug better why did not the wrong version
> > cause any undefined behavior? Sounds like a fatal bug. Does this
> > cause crashes?
>
> AFAIK, no, no crashes. I haven't tested this myself (and I believe
> relatively few people use this functionality, which explains why this
> has not been fixed for so long) but I don't think it will necessarily
> crash. It's just that the frontend driver will be reading from wrong
> location, causing TPM not to function properly.
I bumped my head into this last week and spent most of the
week trying to figure out why the vtpm did not respond.
Finally found the email from the guy that dirscovered and fixed
it. Did the fix and rescompiled. Now it seems to be working
fine. The patch is surprisingly 2 years old!!
I will be very pleased to see it go in to the
official kernel!
But no crash. Just a timeout when trying to communicate with
the vtpm-engine.
Best
Dag
prev parent reply other threads:[~2018-09-18 7:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 21:25 [PATCH v2] tpm: Restore functionality to xen vtpm driver Boris Ostrovsky
2018-09-16 19:25 ` Jarkko Sakkinen
2018-09-17 13:54 ` Boris Ostrovsky
2018-09-17 21:19 ` Jarkko Sakkinen
2018-09-17 22:25 ` Boris Ostrovsky
2018-09-18 6:54 ` Dag Nygren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6898808.CzJHl40L0f@eseries.newtech.fi \
--to=dag@newtech.fi \
--cc=boris.ostrovsky@oracle.com \
--cc=dunlapg@umich.edu \
--cc=greg@enjellic.com \
--cc=greg@wind.enjellic.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=jgross@suse.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).