From: Marcel Holtmann <marcel@holtmann.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: tjiang@codeaurora.org, Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-bluetooth <linux-bluetooth@vger.kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
Balakrishna Godavarthi <bgodavar@codeaurora.org>,
c-hbandi@codeaurora.org, Hemantg <hemantg@codeaurora.org>,
Rocky Liao <rjliao@codeaurora.org>,
zijuhu@codeaurora.org
Subject: Re: [PATCH v3] Bluetooth: btusb: Add support for variant WCN6855 by using different nvm
Date: Thu, 28 Oct 2021 16:00:21 +0200 [thread overview]
Message-ID: <68A15E46-C716-4324-8B5D-C71C9D2753C5@holtmann.org> (raw)
In-Reply-To: <YXl3S7TT30PFfyB8@google.com>
Hi Matthias,
>> the previous patch is submitted by zijun , as he is not working on this
>> project, I take over his job, so can we assume abandon the previous patch,
>> using my new patch ? thank you.
>> regards.
>
> Your patch is clearly based on zijun's one, it even has the same subject. A
> change of authorship shouldn't result in resetting the version number, it's
> still the same patch/series. You can always add a 'Co-developed-by:' tag to
> indicate that someone else contributed to a patch, or use a 'From:' tag if
> you only made minor changes on top of someone else's work.
I really don’t care much since that is for them and their company policy to figure out.
> Not sure how to proceed best with the version number, especially since there
> are already 3 versions of the 'new' patch. Either option can create confusion,
> I guess you can continue with the new scheme, it seems the patch is almost
> ready to land anyway.
It is a total mess already for a dead simple patch like this. And they keep messing it up differently every time.
I provided a btusb_generate_qca_nvm_name() in one of my replies, where the variant variable was declared without NULL assignment and the ram_version was converted from little endian in place. That was 28th of September and 4 patches later the patch is still not ready to be merged. The maintainer hands you the recipe and you still screw up the cake multiple times; I am just done with this.
The next version would be a v16 btw. So seriously, how can we have 15 revisions so far and still not have this in a mergable state?
Regards
Marcel
next prev parent reply other threads:[~2021-10-28 14:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 5:35 [PATCH v3] Bluetooth: btusb: Add support for variant WCN6855 by using different nvm tjiang
2021-10-26 5:53 ` tjiang
2021-10-26 16:24 ` Matthias Kaehlcke
2021-10-27 6:12 ` tjiang
2021-10-27 15:59 ` Matthias Kaehlcke
2021-10-28 7:15 ` tjiang
2021-10-28 14:00 ` Marcel Holtmann [this message]
2021-10-29 3:09 ` tjiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68A15E46-C716-4324-8B5D-C71C9D2753C5@holtmann.org \
--to=marcel@holtmann.org \
--cc=bgodavar@codeaurora.org \
--cc=c-hbandi@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=mka@chromium.org \
--cc=rjliao@codeaurora.org \
--cc=tjiang@codeaurora.org \
--cc=zijuhu@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).