From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
<alexandre.torgue@st.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 3/3] net: stmmac: Make 'alloc_dma_[rt]x_desc_resources()' look even closer
Date: Mon, 10 Jul 2017 08:22:50 +0200 [thread overview]
Message-ID: <68a04948-2a52-56d4-1875-d15540808eed@st.com> (raw)
In-Reply-To: <ea4badb176e009c7485ea4ab83bbe29cd3750d90.1499499451.git.christophe.jaillet@wanadoo.fr>
On 7/8/2017 9:46 AM, Christophe JAILLET wrote:
> 'alloc_dma_[rt]x_desc_resources()' functions look very close.
> Remove a useless initialization and use the same label name for error
> handling path in order to get them even closer.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 07d486a70118..1853f7ff6657 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -1449,7 +1449,7 @@ static void free_dma_rx_desc_resources(struct stmmac_priv *priv)
> static void free_dma_tx_desc_resources(struct stmmac_priv *priv)
> {
> u32 tx_count = priv->plat->tx_queues_to_use;
> - u32 queue = 0;
> + u32 queue;
>
> /* Free TX queue resources */
> for (queue = 0; queue < tx_count; queue++) {
> @@ -1561,13 +1561,13 @@ static int alloc_dma_tx_desc_resources(struct stmmac_priv *priv)
> sizeof(*tx_q->tx_skbuff_dma),
> GFP_KERNEL);
> if (!tx_q->tx_skbuff_dma)
> - goto err_dma_buffers;
> + goto err_dma;
>
> tx_q->tx_skbuff = kmalloc_array(DMA_TX_SIZE,
> sizeof(struct sk_buff *),
> GFP_KERNEL);
> if (!tx_q->tx_skbuff)
> - goto err_dma_buffers;
> + goto err_dma;
>
> if (priv->extend_desc) {
> tx_q->dma_etx = dma_zalloc_coherent(priv->device,
> @@ -1577,7 +1577,7 @@ static int alloc_dma_tx_desc_resources(struct stmmac_priv *priv)
> &tx_q->dma_tx_phy,
> GFP_KERNEL);
> if (!tx_q->dma_etx)
> - goto err_dma_buffers;
> + goto err_dma;
> } else {
> tx_q->dma_tx = dma_zalloc_coherent(priv->device,
> DMA_TX_SIZE *
> @@ -1586,13 +1586,13 @@ static int alloc_dma_tx_desc_resources(struct stmmac_priv *priv)
> &tx_q->dma_tx_phy,
> GFP_KERNEL);
> if (!tx_q->dma_tx)
> - goto err_dma_buffers;
> + goto err_dma;
> }
> }
>
> return 0;
>
> -err_dma_buffers:
> +err_dma:
> free_dma_tx_desc_resources(priv);
>
> return ret;
next prev parent reply other threads:[~2017-07-10 6:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-08 7:46 [PATCH 0/3] net: stmmac: Fixes and cleanups in 'alloc_dma_[rt]x_desc_resources()' Christophe JAILLET
2017-07-08 7:46 ` [PATCH 1/3] net: stmmac: Fix error handling path in 'alloc_dma_rx_desc_resources()' Christophe JAILLET
2017-07-10 6:21 ` Giuseppe CAVALLARO
2017-07-08 7:46 ` [PATCH 2/3] net: stmmac: Fix error handling path in 'alloc_dma_tx_desc_resources()' Christophe JAILLET
2017-07-10 6:22 ` Giuseppe CAVALLARO
2017-07-08 7:46 ` [PATCH 3/3] net: stmmac: Make 'alloc_dma_[rt]x_desc_resources()' look even closer Christophe JAILLET
2017-07-10 6:22 ` Giuseppe CAVALLARO [this message]
2017-07-11 20:34 ` [PATCH 0/3] net: stmmac: Fixes and cleanups in 'alloc_dma_[rt]x_desc_resources()' David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68a04948-2a52-56d4-1875-d15540808eed@st.com \
--to=peppe.cavallaro@st.com \
--cc=alexandre.torgue@st.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).