From: Kishon Vijay Abraham I <kishon@ti.com>
To: "Rafał Miłecki" <rafal@milecki.pl>, "Rafał Miłecki" <zajec5@gmail.com>
Cc: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com>,
Jon Mason <jonmason@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
<linux-arm-kernel@lists.infradead.org>,
<bcm-kernel-feedback-list@broadcom.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 0/5] phy: bcm-ns-usb3: add MDIO driver
Date: Fri, 16 Jun 2017 13:22:05 +0530 [thread overview]
Message-ID: <68b4f1ed-fc3b-77a0-fb6e-f024814a4a66@ti.com> (raw)
In-Reply-To: <30100fc8-7538-fd30-0a6a-665019b38c38@milecki.pl>
Hi,
On Friday 16 June 2017 12:44 PM, Rafał Miłecki wrote:
> On 06/16/2017 08:36 AM, Kishon Vijay Abraham I wrote:
>> On Friday 09 June 2017 01:34 AM, Rafał Miłecki wrote:
>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>
>>> As explained in the commit 9200c6f177638 ("Revert "phy: Add USB3 PHY support
>>> for Broadcom NSP SoC"") this module should be modified to use MDIO bus as
>>> this is how PHY is really attached.
>>>
>>> This should allow reusing this driver on NSP and any other platform with
>>> MDIO bus and this particular PHY.
>>
>> can you run checkpatch and fix all warnings in this series?
>
> I always check my patches before sending. For this set the only warning I
> get is:
>
> WARNING: line over 80 characters
> #117: FILE: drivers/phy/broadcom/phy-bcm-ns-usb3.c:224:
> +
> usecs_to_jiffies(BCM_NS_USB3_MII_MNG_TIMEOUT_US));
>
> I've problem finding a nice way of fixing this.
> 1) I can't break the line between arguments as there is only 1 argument
> 2) I shouldn't use small indention as it would misalign this line
> 3) Using tmp var for BCM_NS_USB3_MII_MNG_TIMEOUT_US sounds a bit pointless
>
> According to the coding-style.rst having 80+ chars lines is acceptable if it
> "significantly increases readability and does not hide information". Maybe
> we can just live with this single line like that? Isn't this a bit bike
> shedding in this case?
Sure, just wanted to make sure we didn't overlook checkpatch warnings.
Thanks
Kishon
next prev parent reply other threads:[~2017-06-16 7:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 13:29 [PATCH for 4.13 0/5] phy: bcm-ns-usb3: add MDIO driver Rafał Miłecki
2017-05-11 13:29 ` [PATCH 1/5] phy: bcm-ns-usb3: always wait for idle after writing to the PHY reg Rafał Miłecki
2017-05-11 13:29 ` [PATCH 2/5] phy: bcm-ns-usb3: use pointer for PHY writing function Rafał Miłecki
2017-05-11 13:29 ` [PATCH 3/5] phy: bcm-ns-usb3: enable MDIO in the platform specific code Rafał Miłecki
2017-05-11 13:29 ` [PATCH 4/5] dt-bindings: phy: Modify Broadcom NS USB 3.0 PHY binding to use MDIO Rafał Miłecki
2017-05-13 0:19 ` Rob Herring
2017-05-11 13:29 ` [PATCH 5/5] phy: bcm-ns-usb3: add MDIO driver using proper bus layer Rafał Miłecki
2017-05-11 16:29 ` Florian Fainelli
2017-06-16 6:04 ` Kishon Vijay Abraham I
2017-06-16 6:11 ` Rafał Miłecki
2017-06-16 6:31 ` Kishon Vijay Abraham I
2017-06-08 20:04 ` [PATCH V2 0/5] phy: bcm-ns-usb3: add MDIO driver Rafał Miłecki
2017-06-08 20:04 ` [PATCH V2 1/5] phy: bcm-ns-usb3: always wait for idle after writing to the PHY reg Rafał Miłecki
2017-06-08 20:04 ` [PATCH V2 2/5] phy: bcm-ns-usb3: use pointer for PHY writing function Rafał Miłecki
2017-06-08 20:04 ` [PATCH V2 3/5] phy: bcm-ns-usb3: enable MDIO in the platform specific code Rafał Miłecki
2017-06-08 20:04 ` [PATCH V2 4/5] dt-bindings: phy: Modify Broadcom NS USB 3.0 PHY binding to use MDIO Rafał Miłecki
2017-06-14 15:26 ` Rob Herring
2017-06-08 20:04 ` [PATCH V2 5/5] phy: bcm-ns-usb3: add MDIO driver using proper bus layer Rafał Miłecki
2017-06-16 6:36 ` [PATCH V2 0/5] phy: bcm-ns-usb3: add MDIO driver Kishon Vijay Abraham I
2017-06-16 7:14 ` Rafał Miłecki
2017-06-16 7:52 ` Kishon Vijay Abraham I [this message]
2017-06-16 7:53 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68b4f1ed-fc3b-77a0-fb6e-f024814a4a66@ti.com \
--to=kishon@ti.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jonmason@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=yendapally.reddy@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).