From: Sibi Sankar <email@example.com> To: Brian Norris <firstname.lastname@example.org> Cc: Bjorn Andersson <email@example.com>, Ohad Ben-Cohen <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH] remoteproc: qcom: q6v5-pil: add SCM probe dependency Date: Tue, 09 Oct 2018 22:51:35 +0530 Message-ID: <email@example.com> (raw) In-Reply-To: <20181009170232.GA86621@ban.mtv.corp.google.com> On 2018-10-09 22:32, Brian Norris wrote: > On Mon, Oct 08, 2018 at 11:21:25PM -0700, Bjorn Andersson wrote: >> On Mon 08 Oct 19:08 PDT 2018, Brian Norris wrote: >> >> > Similar to qcom_q6v5_pas and qcom_wcnss drivers, probe will fail if SCM >> > is not up. >> > >> >> Thanks Brian, this dependency was introduced with the memory ownership >> support. > > That's a good point. I'm actually not that familiar with this > particular > driver--I was just trying to resolve an OOPS I saw while bringing this > driver up--but that does look correct. > >> I applied it with an updated conditional to make it explicit that it >> related to need_mem_protection, updated the commit message to describe >> actual relationship to the memory protection mechanism and added a >> Fixes: tag. > > Your version looks good, thanks. > >> Don't we also need to add the ability to disable need_mem_protection >> when we're running ATF? > > I'm not sure exactly, but FWIW I'm running some form of ATF on SDM845 > and I'm running with 'needs_memory_protection' (hence, this patch). > AFAIK ATF will eventually support the hyp assign calls even though they are just stubs as of now. > Regards, > Brian -- -- Sibi Sankar -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
prev parent reply index Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-09 2:08 Brian Norris 2018-10-09 6:21 ` Bjorn Andersson 2018-10-09 17:02 ` Brian Norris 2018-10-09 17:21 ` Sibi Sankar [this message]
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ email@example.com firstname.lastname@example.org public-inbox-index lkml Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/ public-inbox